Review main Abandoned

93781[BUGFIX] do not pass integer to ContentObjectRenderer->start()

Achim Fritz CR 0 V 0 Easy +1 −1 updated 04/21/26, 14:38

Commit message

if a record is not translated the DatabaseRecordLinkBuilder
should throw an UnableToLinkException
therefore the record needs to be null
this prevents calling the ContentObjectRenderer->start()
method with an integer value

https://review.typo3.org/c/Packages/TYPO3.CMS/+/93654 declares
the  variable passed to the ContentObjectRenderer->start()
as an array

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3

  1. Achim Fritz uploaded patch set 1 04/21/26, 14:27

  2. Garvin Hicking commented on patch set 1 04/21/26, 14:36

    Unresolved

    I think we've had something similar with record = 0 / null shortly before. We should check the codebase for more like this - I can do that the next few days. (Also please let's set Related: here and use uppercase grammar in commit subject and body - I can do that later)
  3. Benni Mack abandoned the change 04/21/26, 14:38

    duplicate