Review main Merged

93788[BUGFIX] Fix undefined array key "task_group" in scheduler task form

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 04/22/26, 04:50

Commit message

When no scheduler task groups exist, the "task_group" key is absent
from the Form Engine incoming data array. Accessing it directly in
str_starts_with() triggers an "undefined array key" PHP warning and
breaks task creation.

Add a null-coalescing fallback so the missing key is treated as an
empty string, which correctly skips the group ID extraction.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 58

  1. Anja Leichsenring uploaded patch set 1 04/22/26, 03:42

  2. core-ci voted on patch set 1 V -1 04/22/26, 04:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100672

  3. core-ci voted on patch set 1 V +1 04/22/26, 04:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100672

  4. Anja Leichsenring commented on patch set 1 04/22/26, 04:17

    with green nightly test run, we don't have any other issues: https://git.typo3.org/typo3/CI/cms/-/pipelines/100672
  5. core-ci commented on patch set 1 04/22/26, 04:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100671

  6. Sven Liebert voted on patch set 1 CR +1 V +1 04/22/26, 04:43

  7. Georg Ringer voted on patch set 1 CR +2 V +2 04/22/26, 04:50

  8. Georg Ringer merged patch set 2 04/22/26, 04:50