Review main Merged

93789[BUGFIX] Normalize non-bool cache compression option

Ravi Sachaniya CR +2 V +2 Normal +78 −0 updated 04/23/26, 08:31

Commit message

Cache backend options are forwarded to typed setter methods.
Legacy system settings wrote `compression` as int `1` or
string `'1'`, which trips `setCompression(bool)`.

The patch casts any non-bool `compression` option to bool in
CacheManager before backend instantiation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Ravi Sachaniya +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Ravi Sachaniya +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1013

  1. Ravi Sachaniya uploaded patch set 1 04/22/26, 05:23

  2. core-ci voted on patch set 1 V +1 04/22/26, 05:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100682

  3. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 07:22

  4. Christian Kuhn uploaded patch set 3 04/23/26, 01:48

  5. core-ci voted on patch set 3 V -1 04/23/26, 01:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100972

  6. Garvin Hicking commented on patch set 4 V -1 04/23/26, 05:23

    Published edit on patch set 3.
  7. core-ci voted on patch set 4 V +1 04/23/26, 05:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100984

  8. Ravi Sachaniya voted on patch set 4 CR +1 V +1 04/23/26, 05:32

  9. Oliver Klee voted on patch set 4 CR +1 V +1 04/23/26, 06:55

  10. Garvin Hicking voted on patch set 4 CR +1 V +1 04/23/26, 07:27

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 04/23/26, 07:56

  12. Benni Mack voted on patch set 4 CR +1 V +1 04/23/26, 08:25

  13. Christian Kuhn merged patch set 5 04/23/26, 08:31