93794[BUGFIX] Recompute sys_file identifier hash on impexp import
Commit message
Review
-
Code review CR -1
- Benjamin Kott -1
- Benni Mack +1
-
Verified V +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/impexp/Classes/Import.php3+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/images-with-static-and-fallback-storages.xml+0 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/images-with-storages.xml+0 −6
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-existing-different-image.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-existing-same-image.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-but-not-included.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-with-forced-uids.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-with-invalid-storage.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-with-spaces-in-path.xml+0 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image-without-storage.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-image.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-missing-image.xml+0 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-rte-image-n-file-link.xml+0 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-site-config.xml+0 −4
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent-with-two-images.xml+4 −8
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/pages-and-ttcontent.xml+0 −4
Review log 1013
-
Benjamin Kott uploaded patch set 1 04/22/26, 07:19
-
Benjamin Kott rebased onto patch set 2 04/22/26, 12:38
-
core-ci voted on patch set 2 V +1 04/22/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100897
-
Benjamin Kott rebased onto patch set 3
V +104/22/26, 22:20 -
core-ci voted on patch set 3 V +1 04/22/26, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100963
-
Benjamin Kott updated the commit message in patch set 4
V +104/23/26, 05:52 -
Benni Mack commented on patch set 4 04/23/26, 06:01
-
Benjamin Kott commented on patch set 4 04/23/26, 06:15
Import.php:633Replythis state does not include identifier_hash, it will be readded with the next, but its also there a computed value we could potentially drop, so prepping it here seems a good idea - but as mentioned not strictly nessesary with the second one -
core-ci voted on patch set 4 V +1 04/23/26, 06:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100986
-
Benni Mack voted on patch set 4 CR +1 V +1 04/23/26, 08:27
-
Benni Mack commented on patch set 4 04/24/26, 08:38
Import.php:633ReplyDone -
Benjamin Kott commented on patch set 4 CR -1 04/24/26, 08:58
Unresolved
still discussing if nessesary or too risky -
Benjamin Kott abandoned the change 04/24/26, 11:55
obsolete bugfix with https://review.typo3.org/c/Packages/TYPO3.CMS/+/93812 for now, also misses to respect driver hash generation of files
Import.php:633