93803[TASK] Convert synchronous XMLHttpRequest userpref to async
Commit message
Review
-
Code review CR -1
- Andreas Kienast -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Garvin Hicking uploaded patch set 1 04/22/26, 18:46
-
Garvin Hicking commented on patch set 1 04/22/26, 18:49
Please note this TypeScript/JavaScript is not my strong suit and I clobbered this together as a first working base to kick off. Needs proper review. -
core-ci voted on patch set 1 V -1 04/22/26, 18:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100924
-
core-ci voted on patch set 1 V +1 04/22/26, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100924
-
Andreas Kienast commented on patch set 1 04/23/26, 05:25
This means that the first call to .get() will now always "fail" and I won't get any data. How is this helpful? -
Andreas Kienast voted on patch set 1 CR -1 04/23/26, 05:25
-
Garvin Hicking commented on patch set 1 04/23/26, 07:44
Reply
Probably not, do you have an idea how to solve it? I need help with this. -
Garvin Hicking commented on patch set 1 04/23/26, 07:47
Reply
(Note this isn't urgent, we'll probably have a while until browsers really kill this) -
Garvin Hicking marked it work in progress 04/23/26, 07:47
-
Andreas Kienast commented on patch set 1 04/23/26, 07:53
Reply
The only solution is to rewrite / replace this with a truly async solution, which of course leads to a deprecation of this very module. -
Garvin Hicking commented on patch set 1 04/23/26, 07:55
Reply Unresolved
Ack. I'll abandon this one and leave the issue open. -
Garvin Hicking abandoned the change 04/23/26, 07:56
Needs the whole nine yards