Review main Merged

93812[BUGFIX] Export full rows minus defaults in impexp

Benjamin Kott CR +2 V +2 Impossible +7183 −7614 updated 04/28/26, 16:41

Commit message

The export filter reduced records to the fields listed in a
sub-schema's showitem, silently dropping columns that downstream code
reads directly — hidden, language pointers and the record-type among
them. Round-tripping an export through an import therefore lost data,
and the preview misread "absent" as "visible".

The filter now works the other way around: the full database row is
the starting point and two classes of fields are stripped.
DataHandler-managed timestamps (tstamp, crdate) drop because import
overwrites them anyway, and columns whose stored value equals the
effective default drop because DataHandler reapplies defaults on
import. TCA is authoritative; only columns without a TCA default fall
back to the Doctrine-reported database default, which covers implicit
type defaults and ext_tables.sql overrides.

Fields preserved regardless of value are uid, pid, the disabled field
(RestrictionDisabledField capability), the record-type field
(ctrl.type, e.g. CType on tt_content or doktype on pages) and the
language capability fields. Per-table setup is cached so capability
lookups and schema introspection run once per table and export.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 53

Show 33 more files

Review log 1523

  1. Benjamin Kott uploaded patch set 1 04/23/26, 05:52

  2. Benjamin Kott updated the commit message in patch set 2 04/23/26, 05:53

  3. core-ci voted on patch set 1 V +1 04/23/26, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100985

  4. core-ci voted on patch set 2 V +1 04/23/26, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100987

  5. Benjamin Franzke uploaded patch set 3 V +1 04/24/26, 07:35

  6. core-ci voted on patch set 3 V +1 04/24/26, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101075

  7. Benjamin Franzke uploaded patch set 4 V +1 04/24/26, 08:24

  8. core-ci voted on patch set 4 V +1 04/24/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101077

  9. Benjamin Kott uploaded patch set 5 V +1 04/24/26, 08:32

  10. core-ci voted on patch set 5 V +1 04/24/26, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101079

  11. Benjamin Kott uploaded patch set 6 V +1 04/24/26, 08:58

  12. core-ci voted on patch set 6 V +1 04/24/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101080

  13. Benjamin Franzke uploaded patch set 7 V +1 04/24/26, 14:15

  14. Benjamin Franzke voted on patch set 7 CR +1 V +1 04/24/26, 14:15

  15. core-ci voted on patch set 7 V +1 04/24/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101091

  16. Benni Mack voted on patch set 7 CR +1 V +1 04/28/26, 09:57

  17. Benjamin Kott voted on patch set 7 CR +2 V +2 04/28/26, 10:45

  18. Benjamin Kott uploaded patch set 8 CR +1 V +1 04/28/26, 13:06

  19. core-ci voted on patch set 8 V +1 04/28/26, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101214

  20. Benni Mack voted on patch set 8 CR +1 V +1 04/28/26, 13:49

  21. Benjamin Franzke voted on patch set 8 CR +1 V +1 04/28/26, 14:43

  22. Benjamin Kott voted on patch set 8 CR +2 V +2 04/28/26, 16:40

  23. Benjamin Kott merged patch set 9 04/28/26, 16:41