93813[BUGFIX] Avoid race conditions in dynamic flatpickr width calculation
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1317
-
Benjamin Franzke uploaded patch set 1 04/23/26, 07:03
-
Benjamin Franzke uploaded patch set 2 04/23/26, 07:12
-
core-ci voted on patch set 1 V +1 04/23/26, 07:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100993
-
core-ci voted on patch set 2 V -1 04/23/26, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100994
-
core-ci voted on patch set 2 V +1 04/23/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100994
-
Garvin Hicking commented on patch set 2 CR +1 V +1 04/23/26, 11:47
Tested this in - formengine full view - formengine context modalpopuppanel - belog filter - new page wizard popup With macOS FireFox and Chromium latest. (Took a bit longer because I tried to verify this with https://review.typo3.org/c/Packages/TYPO3.CMS/+/93824 inside the page wizard too, until I remembered that the wizard only handles `pages` for now and I can't create styleguide records with it. Maybe it'll be of use some time) -
Benjamin Franzke commented on patch set 2 04/23/26, 14:30
Reply
Yea right, that needs manual TCA for pages right now. I tested the original change via ``` diff --git a/typo3/sysext/core/Configuration/TCA/pages.php b/typo3/sysext/core/Configuration/TCA/pages.php index bef314e1615..c999e2a9fb6 100644 --- a/typo3/sysext/core/Configuration/TCA/pages.php +++ b/typo3/sysext/core/Configuration/TCA/pages.php @@ -221,6 +221,14 @@ return [ 'eval' => 'trim', ], ], + 'mydate' => [ + 'label' => 'My Date', + 'config' => [ + 'type' => 'datetime', + 'size' => 50, + 'max' => 255, + ], + ], 'nav_hide' => [ 'exclude' => true, 'label' => 'core.db.pages:nav_hide', @@ -676,12 +684,12 @@ return [ categories, --div--;core.form.tabs:notes, rowDescription, - --div--;core.form.tabs:extended, + --div--;core.form.tabs:extended,mydate ', 'wizardSteps' => [ 'setup' => [ 'title' => 'backend.wizards.page:step.setup', - 'fields' => ['title', 'slug', 'nav_title', 'hidden', 'nav_hide'], + 'fields' => ['title', 'slug', 'mydate', 'nav_title', 'hidden', 'nav_hide'], ], ], ], ``` -
Garvin Hicking commented on patch set 2 04/23/26, 14:57
Reply
(ack; i just enabled starttime+endtime in the wizardstep) -
Andreas Kienast commented on patch set 2 V -1 04/24/26, 11:53
I think we need a min-width or alike. The time picker (e.g. the inputdatetime_12 example) is IMO too narrow and hard to use as its controls overlap the input values. -
Benjamin Franzke uploaded patch set 3
CR +1V +104/24/26, 14:22 -
Benjamin Franzke commented on patch set 3 04/24/26, 14:22
Reply
ack, done. -
core-ci voted on patch set 3 V +1 04/24/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101093
-
Garvin Hicking commented on patch set 3 CR +1 V +1 04/24/26, 14:46
Reply
Retested with my cases, thanks! -
Benjamin Kott voted on patch set 3 CR +1 V +1 04/24/26, 17:29
-
Andreas Kienast voted on patch set 3 CR +1 V +1 04/27/26, 06:17
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 04/27/26, 06:18
-
Benjamin Franzke merged patch set 4 04/27/26, 06:18