Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

93819[WIP][BUGFIX] Guard translated tt_content free-mode moves

Eric Harrer CR -1 V 0 Expert +949 −129 updated 11/12/26, 21:39

Commit message

Require explicit confirmation before moving a default-language
tt_content record with connected translations into a free-mode
target language.

Block unconfirmed moves in DataHandler, delete connected
translations for confirmed root moves inside a rollback-safe
transaction, and add page module confirmation prompts for
paste and drag-and-drop. Functional tests cover blocked,
rollback, confirmed, and empty-target scenarios.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/19/93819/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/19/93819/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Benni Mack -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 20

Review log 46

  1. Eric Harrer uploaded patch set 1 04/23/26, 08:55

  2. core-ci voted on patch set 1 V -1 04/23/26, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101009

  3. Eric Harrer uploaded patch set 2 V -1 04/23/26, 09:46

  4. core-ci voted on patch set 2 V +1 04/23/26, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101018

  5. Eric Harrer marked it work in progress 08/28/26, 21:48

  6. Benni Mack commented on patch set 2 CR -1 11/12/26, 21:39

    Unresolved

    I wanted to check if we're on the right track with this change. The problem is real, but I think the patch aims at the wrong boundary. I tested main with a default language element that has a Danish translation: - move/paste into a language without translations: the element changes its language, the translation keeps l18n_parent pointing to it (the case from the issue) - move/paste into the Danish column (connected mode): same, and now both records are Danish, with l18n_parent pointing to a record of the same language - editing the element and changing sys_language_uid: same orphan So this is not about free mode, move or tt_content: the language of a default language record with connected translations must not change. The patch handles the first case only. In a connected or mixed target isTtContentLanguageInFreeMode() is false and the move goes through unchanged, the edit form is untouched, and tt_content is hard-coded. Concerns with the approach itself: - Deleting translations as a side effect of drag and drop is very destructive for an ambiguous gesture. The issue lists blocking as an acceptable outcome. - The transaction around moveRecord() only rolls back rows, not DataHandler's in-memory state (cache clearing, reference index, delete tracking), and re-indents the whole method. - In workspaces, publishing the moved record without the delete placeholders of its translations recreates the orphans in live. - "Free mode" is determined twice (DataHandler query vs. PageLayoutContext). If both disagree, the editor gets a blocked move without a dialog. - __destructiveMoveConfirmed in the paste update payload becomes API.