Review main Merged

93827[BUGFIX] Fix avatar upload in User Settings with partitioned field names

Himanshu Nitsan CR +2 V +2 Easy +4 −3 updated 05/02/26, 17:25

Commit message

Avatar upload could fail when setup-module.js extracted a different field name
from objectGroup than the one used by AvatarElement DOM ids, causing
getElementById() lookups to return null and triggering a TypeError.

Fix by making irreObjectId dynamic in AvatarElement
(-0-be_users-avatar-<fieldName>) and updating setup-module matching to
/(?:^|-)avatar-(.+)$/ so the full partitioned field name is resolved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Himanshu Nitsan +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Himanshu Nitsan +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Himanshu Nitsan uploaded patch set 1 04/23/26, 12:15

  2. core-ci voted on patch set 1 V -1 04/23/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101037

  3. core-ci commented on patch set 1 04/23/26, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101037

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 04/23/26, 12:56

    Thanks so much for providing a patch here. I think this lightweight approach does the trick. When test, take notice that selecting an avatar will not reveal the avatar directly in the user settings (so it "feels" as if it didn't work to select an avatar), but this behaviour is also already present on v13. So I think we could take this fix in on its own and address other issues seperately.
  5. Himanshu Nitsan commented on patch set 1 CR +1 V +1 04/23/26, 13:10

    Reply

    Hi @garvin@hick.ing Thanks a lot for reviewing and for confirming this approach. I agree to keep this patch focused on the field name mismatch fix only, and handle the preview behavior in a follow-up issue/patch. I noticed the pipeline is currently failing, please let me know if there is anything specific I should address from my side.
  6. core-ci voted on patch set 1 V +1 04/23/26, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101037

  7. Garvin Hicking commented on patch set 1 04/23/26, 15:07

    Reply

    Yes, that error was/is unrelated. I re-ran the pipeline twice. I've forwarded your patch to Olly and Benni who worked on the User Settings separation for review.
  8. Christian Kuhn voted on patch set 1 CR +2 V +2 05/02/26, 17:12

  9. Christian Kuhn merged patch set 2 05/02/26, 17:25