Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
93838[FEATURE] Translate forms in the backend
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 31
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/93838/31 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/38/93838/31 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 85
- Build/Sources/Sass/typo3/_element_tceforms.scss+2 −1
- Build/Sources/Sass/form.scss+9 −0
- Build/Sources/TypeScript/form/backend/form-editor/component/form-element-stage-item-toolbar.ts+3 −0
- Build/Sources/TypeScript/form/backend/form-editor/component/form-element-stage-item.ts+4 −2
- Build/Sources/TypeScript/form/backend/form-editor/component/property-grid-editor.ts+14 −0
- Build/Sources/TypeScript/form/backend/form-editor/core.ts+41 −0
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+404 −64
- Build/Sources/TypeScript/form/backend/form-editor/mediator.ts+28 −1
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+62 −34
- Build/Sources/TypeScript/form/backend/form-editor/tree-component-adapter.ts+14 −1
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+11 −2
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+50 −0
- Build/Sources/TypeScript/form/backend/form-editor-tree-container.ts+6 −0
- Build/Sources/TypeScript/form/backend/form-editor-tree.ts+8 −0
- Build/Sources/TypeScript/form/backend/form-editor.ts+332 −2
- Build/Sources/TypeScript/form/tests/form-editor-test.tsnew+30 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-100022-TranslateFormsInTheBackend.rstnew+70 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+123 −22
- typo3/sysext/form/Classes/Controller/FormManagerController.php+105 −0
Show 65 more files
- typo3/sysext/form/Classes/Domain/DTO/FormMetadata.php+8 −0
- typo3/sysext/form/Classes/Domain/DTO/TranslationContext.phpnew+41 −0
- typo3/sysext/form/Classes/Domain/Repository/FormDefinitionRepository.php+45 −2
- typo3/sysext/form/Classes/Domain/Repository/FormDefinitionTranslationRepository.phpnew+289 −0
- typo3/sysext/form/Classes/Preview/FormPagePreviewRenderer.php+1 −1
- typo3/sysext/form/Classes/Service/FormDefinitionOverlayProcessor.phpnew+442 −0
- typo3/sysext/form/Classes/Service/FormTranslationService.phpnew+324 −0
- typo3/sysext/form/Classes/Service/LanguageSelectorFactory.phpnew+153 −0
- typo3/sysext/form/Classes/Storage/DatabaseStorageAdapter.php+49 −6
- typo3/sysext/form/Configuration/Backend/Modules.php+2 −2
- typo3/sysext/form/Configuration/Form/Base/FormElements/AdvancedPassword.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Checkbox.yaml+3 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/ContentElement.yaml+2 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/CountrySelect.yaml+4 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Date.yaml+10 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Email.yaml+9 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Fieldset.yaml+2 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/FileUpload.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Form.yaml+19 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/GridColumn.yaml+2 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/GridRow.yaml+2 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Hidden.yaml+4 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Honeypot.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/ImageUpload.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiCheckbox.yaml+5 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiSelect.yaml+5 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Number.yaml+10 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Password.yaml+9 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/RadioButton.yaml+3 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/SingleSelect.yaml+3 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/StaticText.yaml+2 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Telephone.yaml+9 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Text.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Textarea.yaml+8 −0
- typo3/sysext/form/Configuration/Form/Base/FormElements/Url.yaml+9 −0
- typo3/sysext/form/Configuration/TCA/form_definition.php2+9 −0
- typo3/sysext/form/Documentation/I/Concepts/FormManager/Index.rst+53 −3
- typo3/sysext/form/Documentation/I/HowTos/CustomFormElement/Index.rst+24 −0
- typo3/sysext/form/Documentation/I/HowTos/CustomFormElement/_CustomFormSetup.yaml+1 −0
- typo3/sysext/form/Documentation/QuickStartForIntegrators/Index.rst+7 −3
- typo3/sysext/form/Resources/Private/Language/Database.xlf+42 −0
- typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf+9 −0
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.fluid.html+103 −1
- typo3/sysext/form/Resources/Public/Css/form.css+2 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/form-element-stage-item-toolbar.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/form-element-stage-item.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/component/property-grid-editor.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/core.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/mediator.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/tree-component-adapter.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor-tree-container.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor-tree.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor.js+3 −3
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+10 −0
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+11 −0
- typo3/sysext/form/Tests/Functional/Storage/Fixtures/form_definition_translation_before_parent.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/Storage/DatabaseStorageAdapterFunctionalTest.php+47 −0
- typo3/sysext/form/Tests/Functional/Storage/FormDefinitionRepositoryTest.php+21 −0
- typo3/sysext/form/Tests/Functional/Storage/FormDefinitionTranslationRepositoryTest.phpnew+100 −0
- typo3/sysext/form/Tests/Unit/Service/FormDefinitionOverlayProcessorTest.phpnew+455 −0
- typo3/sysext/form/Tests/Unit/Service/FormTranslationServiceTest.phpnew+168 −0
Review log 4071
Show 2546 earlier messages
-
Josua Vogel uploaded patch set 1 04/24/26, 13:10
-
core-ci voted on patch set 1 V -1 04/24/26, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101085
-
Josua Vogel uploaded patch set 2
V -104/24/26, 13:31 -
core-ci voted on patch set 2 V -1 04/24/26, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101088
-
Josua Vogel uploaded patch set 3
V -104/24/26, 15:12 -
core-ci voted on patch set 3 V -1 04/24/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101096
-
Josua Vogel uploaded patch set 4
V -104/24/26, 15:53 -
core-ci voted on patch set 4 V -1 04/24/26, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101099
-
Josua Vogel uploaded patch set 5
V -104/24/26, 18:05 -
core-ci voted on patch set 5 V -1 04/24/26, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101102
-
Josua Vogel uploaded patch set 6
V -105/14/26, 10:01 -
core-ci voted on patch set 6 V -1 05/14/26, 10:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102027
-
Josua Vogel uploaded patch set 7
V -105/14/26, 10:43 -
core-ci voted on patch set 7 V -1 05/14/26, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102028
-
Josua Vogel uploaded patch set 8
V -105/14/26, 10:58 -
core-ci voted on patch set 8 V -1 05/14/26, 11:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102029
-
Josua Vogel marked it work in progress 05/14/26, 18:02
-
Josua Vogel uploaded patch set 9
V -109/04/26, 11:46 -
core-ci voted on patch set 9 V -1 09/04/26, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107865
-
Josua Vogel uploaded patch set 10
V -109/04/26, 12:25 -
core-ci voted on patch set 10 V -1 09/04/26, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107870
-
Josua Vogel uploaded patch set 11
V -109/04/26, 13:06 -
core-ci voted on patch set 11 V -1 09/04/26, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107874
-
Josua Vogel uploaded patch set 12
V -109/04/26, 13:14 -
Josua Vogel uploaded patch set 13 09/04/26, 13:16
-
Josua Vogel uploaded patch set 14 09/04/26, 13:23
-
core-ci voted on patch set 13 V -1 09/04/26, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107876
-
core-ci voted on patch set 12 V -1 09/04/26, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107875
-
core-ci voted on patch set 14 V -1 09/04/26, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107877
-
Josua Vogel uploaded patch set 15
V -109/04/26, 13:44 -
Josua Vogel uploaded patch set 16 09/04/26, 13:46
-
Josua Vogel uploaded patch set 17 09/04/26, 13:48
-
Josua Vogel marked it ready for review 09/04/26, 13:48
-
core-ci voted on patch set 15 V -1 09/04/26, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107883
-
core-ci voted on patch set 16 V -1 09/04/26, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107884
-
core-ci voted on patch set 17 V +1 09/04/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107885
-
Maike Kiebele commented on patch set 17 09/07/26, 09:32
The preview in the BE doesn't show any translated content -
Josua Vogel uploaded patch set 18
V +109/26/26, 09:29 -
Josua Vogel commented on patch set 18 09/26/26, 09:29
Reply
Done -
core-ci voted on patch set 18 V +1 09/26/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109327
-
Josua Vogel uploaded patch set 19
V +109/26/26, 10:01 -
core-ci voted on patch set 19 V +1 09/26/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109328
-
Josua Vogel uploaded patch set 20
V +110/02/26, 13:20 -
core-ci voted on patch set 20 V +1 10/02/26, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109944
-
Josua Vogel uploaded patch set 21
V +110/08/26, 06:13 -
core-ci voted on patch set 21 V +1 10/08/26, 06:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110446
-
Josua Vogel uploaded patch set 22
V +110/08/26, 07:11 -
core-ci voted on patch set 22 V +1 10/08/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110464
-
Benni Mack commented on patch set 22 10/08/26, 19:40
form_definition.php:43we have to fix this. It has to be unique, but probably unique-per-language -
Josua Vogel uploaded patch set 23
V +110/09/26, 06:50 -
Josua Vogel commented on patch set 23 10/09/26, 06:50
form_definition.php:43Replyadded unique again, thx. unique per language isn't necessary. I would say that unique and l10n_mode exclude mean unique in the default language and translations inherit this value. -
core-ci voted on patch set 23 V -1 10/09/26, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110554
-
Josua Vogel rebased onto patch set 24
V -110/09/26, 09:24 -
core-ci voted on patch set 24 V +1 10/09/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110574
-
Lina Wolf commented on patch set 24 10/15/26, 11:04
The form manual on main was re-indented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/96702 (two spaces after "..", 4-space levels, headline levels). This change will probably conflict in typo3/sysext/form/Documentation when rebased. The script used for the conversion can help to bring new text into the same format; ask me if you need it. -
Josua Vogel uploaded patch set 25
V +110/15/26, 21:01 -
Josua Vogel uploaded patch set 26 10/15/26, 21:06
-
core-ci voted on patch set 25 V -1 10/15/26, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111267
-
core-ci voted on patch set 26 V -1 10/15/26, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111281
-
Josua Vogel uploaded patch set 27
V -110/15/26, 21:56 -
core-ci voted on patch set 27 V +1 10/15/26, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111285
-
Josua Vogel uploaded patch set 28
V +111/15/26, 17:07 -
core-ci voted on patch set 28 V +1 11/15/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114554
-
Dennis Purisevic commented on patch set 28 11/16/26, 13:47
The feature looks and feels pretty solid, but there is a problem with having two sites with different language setups. **Site 1** English [0] Französisch [1] **Site 2** Deutsch [0] English [2] **Problem** What is now the default language for the form? Since forms are saved on `pid 0`, there is no connection to a site, and therefore it can be any language with `language id 0`. I don’t know if a form will be used cross-site, since we’ve updated forms to be site-specific, but if it’s possible for the user to configure this, it must be handled by the system. **Possible solution** Maybe the form can first be created for a specific language, and then a translation can be created, like in the site configuration, where the user has a dropdown. -
Josua Vogel uploaded patch set 29
V +111/17/26, 18:32 -
Josua Vogel commented on patch set 29 11/17/26, 18:33
Reply
Forms live on pid 0 and are not bound to a site, so – like translated file metadata – a translation is keyed by language ID across the installation. This is now documented in the changelog and the manual; binding forms to a site would be a separate feature. -
core-ci voted on patch set 29 V +1 11/17/26, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114776
-
Josua Vogel uploaded patch set 30
V +111/17/26, 18:41 -
core-ci voted on patch set 30 V +1 11/17/26, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114777
-
Josua Vogel uploaded patch set 31
V +111/19/26, 16:35 -
core-ci voted on patch set 31 V +1 11/19/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115027