Review main Merged

93839[BUGFIX] Merge deprecated EMU::addFieldsToUserSettings user settings

Garvin Hicking CR +2 V +2 Easy +8 −0 updated 04/28/26, 14:43

Commit message

With the TCA backend user settings implementation in #108843,
the legacy way of utilizing

```
  ExtensionManagementUtility::addFieldsToUserSettings(...)
```

should have worked in a backwards compatible deprecated way.

However, the legacy notation was not merged to the final
TCA definition, and made user-defined columns not show up.

Note: This does not fix that legacy definitions for "after:"
no longer are properly sorted, custom fields appear
at the end even if they define `after:emailMeAtLogin`.
This may probably happen due to the introduced partitioning format
and needs investigation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 68

  1. Garvin Hicking uploaded patch set 1 04/24/26, 15:21

  2. Garvin Hicking uploaded patch set 2 04/24/26, 15:22

  3. core-ci voted on patch set 1 V +1 04/24/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101097

  4. core-ci voted on patch set 2 V +1 04/24/26, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101098

  5. Benni Mack voted on patch set 2 CR +1 V +1 04/27/26, 06:41

  6. Josua Vogel voted on patch set 2 CR +1 04/27/26, 08:32

  7. Benni Mack voted on patch set 2 CR +2 V +2 04/28/26, 14:43

  8. Benni Mack merged patch set 3 04/28/26, 14:43