Review main Merged

93843[BUGFIX] Invalidate page cache on project path change

Mathias Brodala CR +2 V +2 Easy +2 −0 updated 05/04/26, 17:02

Commit message

This ensures that e.g. rolling-release deployments always trigger a page
content re-render and fresh cache after release switch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Mathias Brodala uploaded patch set 1 04/27/26, 07:57

  2. core-ci voted on patch set 1 V +1 04/27/26, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101151

  3. Helmut Hummel commented on patch set 1 CR -1 04/27/26, 08:51

    PrepareTypoScriptFrontendRendering.php:324

    while this seems to work, I'd rater not inject an object of this class and use the static call instead
  4. Helmut Hummel commented on patch set 1 04/27/26, 08:55

    I like the idea of doing so in general. I'm not sure though if this can really be handled as bugfix, or whether this might have implications that will break current deployments
  5. Mathias Brodala uploaded patch set 2 CR -1 V +1 04/27/26, 09:36

  6. Mathias Brodala commented on patch set 2 04/27/26, 09:39

    Reply

    Unless I'm missing something the most noticeable change can be additional (obsolete) page cache entries which will stay unless caches are flushed. In addition we are using this solution for a few months in production (via "createHashBase" hook in TYPO3v12 however) just fine.

    PrepareTypoScriptFrontendRendering.php:324 Reply

    True, didn't notice the method is static back then. Changed now.
  7. core-ci voted on patch set 2 V +1 04/27/26, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101156

  8. Garvin Hicking commented on patch set 2 CR +1 V +1 04/27/26, 10:31

    I'd be good with this in v14 scope as suggested; wouldn't do it to v13 anymore. I think now is a fair time still to put this into v14. Currently can't think of a situation where it might create trouble, as it's all "just" a part of the hash that is one-way.
  9. Christian Kuhn commented on patch set 2 CR +2 V +2 05/02/26, 16:07

    Reply

    yeah. like garvin, i'm fine with v14 and up.
  10. Christian Kuhn merged patch set 3 05/02/26, 16:55

  11. Helmut Hummel commented on patch set 3 05/04/26, 17:02

    Reply

    Well, juet for the record: Previously page caches survived a deployment. With this change, page cache is empty with each deployment (given path changes) I can see the benefits, however I can also imagine sites going down when set to live with empty caches. Could be fine with v14 though