Review main Abandoned

93845[BUGFIX] Add accessible description to thumbnail toggle button

Christian Rath-Ulrich CR 0 V 0 Easy +24 −4 updated 10/22/26, 14:50

Commit message

Add an ARIA description for the file reference thumbnail toggle
button to improve screen reader accessibility.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 2329

Show 24 earlier messages
  1. Christian Rath-Ulrich uploaded patch set 1 04/27/26, 10:19

  2. Oliver Klee updated the commit message in patch set 2 04/27/26, 10:23

  3. core-ci voted on patch set 1 V +1 04/27/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101159

  4. core-ci voted on patch set 2 V -1 04/27/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101160

  1. Christian Rath-Ulrich updated the commit message in patch set 3 V -1 04/29/26, 12:23

  2. core-ci voted on patch set 3 V +1 04/29/26, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101269

  3. Jennifer Geiß voted on patch set 3 V +1 04/30/26, 07:37

  4. Jennifer Geiß voted on patch set 3 CR +1 04/30/26, 07:37

  5. Christian Jung voted on patch set 3 CR +1 04/30/26, 12:16

  6. Christian Jung voted on patch set 3 V +1 04/30/26, 12:17

  7. Christian Kuhn commented on patch set 3 05/02/26, 10:43

    FileReferenceContainer.php:278

    'Collapse' and 'Expand' should be localizable, shouldn't they?
  8. Christian Kuhn commented on patch set 3 05/02/26, 10:43

    FileReferenceContainer.php:278 Reply

    maybe there is a label for that already?
  9. Christian Kuhn wrote 06/18/26, 23:03

    Removed cc Christian Kuhn.
  10. Christian Rath-Ulrich uploaded patch set 4 CR +1 V +1 06/22/26, 09:01

  11. Christian Rath-Ulrich commented on patch set 4 06/22/26, 09:08

    FileReferenceContainer.php:278 Reply

    there is no matching lable for this context so i added one
  12. Jennifer Geiß voted on patch set 4 CR +1 06/22/26, 09:09

  13. Jennifer Geiß voted on patch set 4 V +1 06/22/26, 09:09

  14. core-ci voted on patch set 4 V +1 06/22/26, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103732

  15. Thorsten Müller voted on patch set 4 CR +1 V +1 06/22/26, 10:28

  16. Christian Rath-Ulrich voted on patch set 4 V +1 06/22/26, 10:30

  17. Christian Jung voted on patch set 4 CR +1 06/22/26, 11:06

  18. Christian Jung voted on patch set 4 V +1 06/22/26, 11:06

  19. Christian Rath-Ulrich voted on patch set 4 CR +1 09/09/26, 13:41

  20. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 09/10/26, 09:06

  21. core-ci voted on patch set 5 V -1 09/10/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108242

  22. Garvin Hicking commented on patch set 6 V -1 10/02/26, 06:48

    Published edit on patch set 5.
  23. core-ci voted on patch set 6 V +1 10/02/26, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109871

  24. Garvin Hicking commented on patch set 6 10/02/26, 07:10

    Unresolved

    When reviewing this I found out that neither with the patch nor without the patch my browser (chrome) shows a "mouseover" for the image (or the toggle button). Is that the expected behaviour? I don't have screenreader functionality setup, but I wonder if there's a way to make regular "tooltips" work too? What am I missing? 😊
  25. Christian Rath-Ulrich abandoned the change 10/22/26, 14:50