93847[BUGFIX] Cast group identifier to string in foreach key variable
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- Jörg Bösche +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 910
-
Nikita Hovratov uploaded patch set 1 04/27/26, 11:32
-
core-ci voted on patch set 1 V +1 04/27/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101165
-
Oliver Klee voted on patch set 1 CR +1 04/27/26, 12:15
-
Oliver Klee voted on patch set 1 V +1 04/27/26, 12:48
-
Georg Ringer voted on patch set 1 CR +1 V +1 04/27/26, 14:38
-
Jörg Bösche voted on patch set 1 CR +1 04/28/26, 06:35
-
Oliver Klee commented on patch set 1 04/30/26, 07:55
-
Nikita Hovratov commented on patch set 1 04/30/26, 12:46
SelectItemProcessor.php:123ReplyI think the real solution is not to use php arrays for itemGroups in the first place. We need a data structure that ensures all keys and values are strings. But this is for another time maybe. -
Christian Kuhn commented on patch set 1 CR +2 V +2 05/02/26, 10:33
SelectItemProcessor.php:123ReplyDone -
Christian Kuhn merged patch set 2 05/02/26, 10:50
SelectItemProcessor.php:123