93853[DOCS] Add changelog entry for CType/colPos locked on translations
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Eric Harrer +1
- André Buchmann +1
-
Verified V +2 Done
- Christian Kuhn +2
- Eric Harrer +1
- André Buchmann +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1727
Show 12 earlier messages
-
core-ci voted on patch set 1 V +1 04/27/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101173
-
Johannes Seipelt commented on patch set 2 04/27/26, 13:03
this patch was created with the help of claude (Sonnet 4.6) -
core-ci voted on patch set 2 V +1 04/27/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101174
-
Garvin Hicking commented on patch set 2 04/27/26, 14:08
Reply
https://review.typo3.org/c/Packages/TYPO3.CMS/+/93852 is a dupe of this then? Please abandon one of the two then and implement the suggestions. Please push that as a new patchset to one of the existing issues here, and not create a third patch. Thanks! See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/ -
Johannes Seipelt commented on patch set 2 04/27/26, 14:42
Reply
Seems like i cannot abandon the https://review.typo3.org/c/Packages/TYPO3.CMS/+/93852 -
Garvin Hicking commented on patch set 2 04/27/26, 14:59
Reply
I can do that for you, just tell me if I should abandon this 93853 or 93852 - don't want to make it harder for you. Thanks for contributing! -
Johannes Seipelt uploaded patch set 3
V +104/27/26, 15:09 -
Johannes Seipelt commented on patch set 3 04/27/26, 15:10
Reply
you can abandon 93852 - thanks 😊 I did the changes suggested in 93852 -
core-ci voted on patch set 3 V +1 04/27/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101181
-
Eric Harrer commented on patch set 3 04/28/26, 14:40
I think this is useful: the technical consistency fix can still create upgrade work for projects that have existing connected translations with divergent CType values.Clarify the scope: refer to connected tt_content translations instead of translated content elements in general.Sharpen the technical description: describe the behavior as synchronizing CType/colPos to the default-language parent values.Maybe avoid “any translated record” here, as the wizard targets connected translations with a default-language parent.Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:15Could we say "connected tt_content translations" here? "translated records" sounds broader than the actual scope and may include free-mode translations, which are not affected.Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:35The wizard scope could be more precise: it updates connected tt_content translations whose CType or colPos differs from their default-language parent.Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:45I would avoid recommending to unset l10n_mode here. Divergent CTypes in connected translations should not read as a supported integration pattern.SynchronizeColPosAndCTypeWithDefaultLanguage.php:43Could we use "connected tt_content translations" here as well? Free-mode translated content records are not affected by this wizard.SynchronizeColPosAndCTypeWithDefaultLanguage.php:46"silently changed" feels a bit too strong here. Maybe use "will be changed to match the parent" and keep the focus on backup/editorial review. -
Johannes Seipelt uploaded patch set 4
V +104/28/26, 14:56 -
Johannes Seipelt commented on patch set 4 04/28/26, 15:00
Reply
DoneReply
DoneReply
DoneImportant-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:15ReplyDoneImportant-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:35ReplyDoneImportant-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:45ReplyDoneSynchronizeColPosAndCTypeWithDefaultLanguage.php:43ReplyDoneSynchronizeColPosAndCTypeWithDefaultLanguage.php:46ReplyDone -
core-ci voted on patch set 4 V -1 04/28/26, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218
-
Eric Harrer commented on patch set 4 CR +1 V +1 04/28/26, 15:41
Thanks, my review points are addressed. The CI failure seems to be unrelated. -
core-ci commented on patch set 4 04/28/26, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218
-
core-ci voted on patch set 4 V +1 04/28/26, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218
-
Garvin Hicking updated the commit message in patch set 5
CR +1V +104/29/26, 05:46 -
core-ci voted on patch set 5 V +1 04/29/26, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101240
-
Garvin Hicking updated the commit message in patch set 6
V +104/29/26, 08:36 -
André Buchmann voted on patch set 6 CR +1 V +1 04/29/26, 08:39
-
core-ci voted on patch set 6 V -1 04/29/26, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101248
-
core-ci voted on patch set 6 V +1 04/29/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101248
-
Eric Harrer voted on patch set 6 CR +1 V +1 04/29/26, 11:28
-
Christian Kuhn voted on patch set 6 CR +2 V +2 06/04/26, 17:26
-
Christian Kuhn merged patch set 7 06/04/26, 17:47