Review main Merged

93853[DOCS] Add changelog entry for CType/colPos locked on translations

TYPO3com CR +2 V +2 Normal +55 −1 updated 06/04/26, 17:47

Commit message

The upgrade wizard introduced in #60357 (TYPO3 13.3) lacked a changelog
entry entirely, and its description gave no indication that it
overwrites data on connected tt_content translations.

This patch adds the missing Important-60357 changelog entry explaining
the behavioral change (CType and colPos are synchronized to the
default-language parent values on connected tt_content translations),
the impact on editors and integrators, and a clear warning that the
upgrade wizard overwrites CType/colPos values on connected translations
that differ from their parent — including intentionally different ones.

The wizard description is updated accordingly to surface the
data-overwrite risk and recommend a database backup before execution.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Eric Harrer +1
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Eric Harrer +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1727

Show 12 earlier messages
  1. TYPO3com uploaded patch set 1 04/27/26, 12:53

  2. Johannes Seipelt updated the commit message in patch set 2 04/27/26, 12:57

  1. core-ci voted on patch set 1 V +1 04/27/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101173

  2. Johannes Seipelt commented on patch set 2 04/27/26, 13:03

    this patch was created with the help of claude (Sonnet 4.6)
  3. core-ci voted on patch set 2 V +1 04/27/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101174

  4. Garvin Hicking commented on patch set 2 04/27/26, 14:08

    Reply

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/93852 is a dupe of this then? Please abandon one of the two then and implement the suggestions. Please push that as a new patchset to one of the existing issues here, and not create a third patch. Thanks! See: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/
  5. Johannes Seipelt commented on patch set 2 04/27/26, 14:42

    Reply

  6. Garvin Hicking commented on patch set 2 04/27/26, 14:59

    Reply

    I can do that for you, just tell me if I should abandon this 93853 or 93852 - don't want to make it harder for you. Thanks for contributing!
  7. Johannes Seipelt uploaded patch set 3 V +1 04/27/26, 15:09

  8. Johannes Seipelt commented on patch set 3 04/27/26, 15:10

    Reply

    you can abandon 93852 - thanks 😊 I did the changes suggested in 93852
  9. core-ci voted on patch set 3 V +1 04/27/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101181

  10. Eric Harrer commented on patch set 3 04/28/26, 14:40

    I think this is useful: the technical consistency fix can still create upgrade work for projects that have existing connected translations with divergent CType values.
    Clarify the scope: refer to connected tt_content translations instead of translated content elements in general.
    Sharpen the technical description: describe the behavior as synchronizing CType/colPos to the default-language parent values.
    Maybe avoid “any translated record” here, as the wizard targets connected translations with a default-language parent.

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:15

    Could we say "connected tt_content translations" here? "translated records" sounds broader than the actual scope and may include free-mode translations, which are not affected.

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:35

    The wizard scope could be more precise: it updates connected tt_content translations whose CType or colPos differs from their default-language parent.

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:45

    I would avoid recommending to unset l10n_mode here. Divergent CTypes in connected translations should not read as a supported integration pattern.

    SynchronizeColPosAndCTypeWithDefaultLanguage.php:43

    Could we use "connected tt_content translations" here as well? Free-mode translated content records are not affected by this wizard.

    SynchronizeColPosAndCTypeWithDefaultLanguage.php:46

    "silently changed" feels a bit too strong here. Maybe use "will be changed to match the parent" and keep the focus on backup/editorial review.
  11. Johannes Seipelt uploaded patch set 4 V +1 04/28/26, 14:56

  12. Johannes Seipelt commented on patch set 4 04/28/26, 15:00

    Reply

    Done

    Reply

    Done

    Reply

    Done

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:15 Reply

    Done

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:35 Reply

    Done

    Important-60357-CTypeAndColPosLockedForTranslatedContentElements.rst:45 Reply

    Done

    SynchronizeColPosAndCTypeWithDefaultLanguage.php:43 Reply

    Done

    SynchronizeColPosAndCTypeWithDefaultLanguage.php:46 Reply

    Done
  13. core-ci voted on patch set 4 V -1 04/28/26, 15:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218

  14. Eric Harrer commented on patch set 4 CR +1 V +1 04/28/26, 15:41

    Thanks, my review points are addressed. The CI failure seems to be unrelated.
  15. core-ci commented on patch set 4 04/28/26, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218

  16. core-ci voted on patch set 4 V +1 04/28/26, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101218

  17. Garvin Hicking updated the commit message in patch set 5 CR +1 V +1 04/29/26, 05:46

  18. core-ci voted on patch set 5 V +1 04/29/26, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101240

  19. Garvin Hicking updated the commit message in patch set 6 V +1 04/29/26, 08:36

  20. André Buchmann voted on patch set 6 CR +1 V +1 04/29/26, 08:39

  21. core-ci voted on patch set 6 V -1 04/29/26, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101248

  22. core-ci voted on patch set 6 V +1 04/29/26, 09:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101248

  23. Eric Harrer voted on patch set 6 CR +1 V +1 04/29/26, 11:28

  24. Christian Kuhn voted on patch set 6 CR +2 V +2 06/04/26, 17:26

  25. Christian Kuhn merged patch set 7 06/04/26, 17:47