93854[BUGFIX] Guard missing titleLen in backend user UC
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1316
-
Himanshu Nitsan uploaded patch set 1 04/27/26, 14:09
-
Garvin Hicking commented on patch set 1 04/27/26, 14:12
-
core-ci voted on patch set 1 V +1 04/27/26, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101175
-
Himanshu Nitsan commented on patch set 1 04/27/26, 14:20
BackendUtility.php:1421ReplyThanks for the feedback, before I update the patch, I’d like to confirm the approach. Instead of hardcoding fallback values in BackendUtility/GridColumnItem, I plan to normalize missing UC defaults centrally in BackendUserAuthentication::backendSetUC(). For existing non-empty UC records, this would backfill missing keys from uc_default + BE defaultUC + TSconfig setup.default, and persist the normalized UC. This should cover not only titleLen, but other missing UC keys as well. Does this approach look okay? -
Garvin Hicking commented on patch set 1 04/27/26, 14:33
BackendUtility.php:1421ReplyI think it should be sufficient to fetch the defaults from the TCA defaults, rather keep it simple and stupid before you begin to evaluate TSconfig / TCADefaults. After a user has saved their UC once, the code should already align. And I believe the old defaults where also just inherited from ` $GLOBALS['TYPO3_USER_SETTINGS']`. -
Himanshu Nitsan commented on patch set 1 04/27/26, 15:08
BackendUtility.php:1421ReplyI updated the patch set with the requested approach. Changes made: - Reworked the fix to backfill missing UC keys from UserSettingsSchema defaults in BackendUserAuthentication::backendSetUC(). - Removed the previous hardcoded fallback handling from call sites. I have used this: git commit --amend still it's create new one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93858 -
Garvin Hicking commented on patch set 1 04/27/26, 15:23
BackendUtility.php:1421ReplyYou'll have to ensure your git working dir is "on this patch" (use the 3rd option in the "download" popup here for example). Then the "Change-Id" must be the same when you git commit, and the push will ammend your commit as a patchset here. Maybe you can try that, and then abandon the dupe? As for the solution, will have to investigate, might take me a bit of time. -
Himanshu Nitsan uploaded patch set 2
V +104/27/26, 15:31 -
Himanshu Nitsan commented on patch set 2 04/27/26, 15:33
BackendUtility.php:1421ReplyYes, I will take care next time about the Change-Id. -
Himanshu Nitsan commented on patch set 2 04/27/26, 15:36
BackendUtility.php:1421ReplyDone -
core-ci voted on patch set 2 V +1 04/27/26, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101182
-
Himanshu Nitsan rebased onto patch set 3
V +110/02/26, 06:58 -
core-ci voted on patch set 3 V +1 10/02/26, 07:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109873
-
Benni Mack voted on patch set 3 CR +1 V +1 10/02/26, 15:01
-
Garvin Hicking voted on patch set 3 CR +2 V +2 10/02/26, 15:39
-
Garvin Hicking merged patch set 4 10/08/26, 16:42
BackendUtility.php:1421