Review main Merged

93861[BUGFIX] Set LinkResult type to page for page links

Steffen Mächtel CR +2 V +2 Easy +1 −1 updated 04/28/26, 07:39

Commit message

Ensure that PageLinkBuilder sets the LinkResult type
to page for page links instead of an empty string, aligning
it with other link builders like file which already set a
proper type.

This fixes incorrect or missing type information for t3://page
links in TYPO3 v14.3.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1

Issues 2

Files 1

Review log 810

  1. Steffen Mächtel uploaded patch set 1 04/27/26, 18:49

  2. core-ci voted on patch set 1 V +1 04/27/26, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101185

  3. Benni Mack commented on patch set 1 CR +1 V +1 04/28/26, 06:18

    thanks for the fix. introduced with this change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91291
  4. Garvin Hicking voted on patch set 1 CR +2 V +2 04/28/26, 07:01

  5. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 04/28/26, 07:04

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 04/28/26, 07:16

  7. Benni Mack voted on patch set 2 CR +1 V +1 04/28/26, 07:17

  8. Benni Mack voted on patch set 2 CR +2 V +2 04/28/26, 07:17

  9. Benni Mack merged patch set 3 04/28/26, 07:17

  10. core-ci voted on patch set 2 V +1 04/28/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101204