Review main Merged

93862[DOCS] Prevent marking ExampleReactionType class as readonly

Stefan Froemken CR +2 V +2 Easy +9 −0 updated 05/02/26, 15:40

Commit message

Add a precautionary comment to inform about incompatibility
with PHP 8.2. Marking the class as readonly would prevent
lazy proxy generation, causing fatal errors during container
compilation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Froemken uploaded patch set 1 04/27/26, 20:20

  2. core-ci voted on patch set 1 V +1 04/27/26, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101186

  3. Garvin Hicking updated the commit message in patch set 2 V +1 04/27/26, 21:09

  4. core-ci voted on patch set 2 V +1 04/27/26, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101187

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 05/02/26, 14:32

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 05/02/26, 15:30

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 05/02/26, 15:31

  8. Christian Kuhn merged patch set 3 05/02/26, 15:40