93872[BUGFIX] Make kbd context aware
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/Sass/component/_kbd.scss4new+49 −0
- Build/Sources/Sass/_minimal.scss+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+4 −1
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Styles/Typography.fluid.html+48 −0
Review log 1418
-
Benjamin Kott uploaded patch set 1 04/28/26, 10:43
-
core-ci voted on patch set 1 V +1 04/28/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101209
-
Riccardo De Contardi commented on patch set 1 V +1 04/29/26, 08:55
tested on latest main 15.0.0 -
Georg Ringer voted on patch set 1 CR +1 V +1 04/29/26, 19:36
-
Benjamin Franzke commented on patch set 1 04/30/26, 08:10
_kbd.scss:13This mixes a lighter color than the background in dark mode and therefore creates a glow instead of a shadow (that is generated in light mode). I suggest a dark shadow instead of a light glow in dark-mode, some value like `#181818` -
Benjamin Kott uploaded patch set 2
CR +1V +105/04/26, 08:21 -
Benjamin Kott uploaded patch set 3 05/04/26, 08:27
-
Benjamin Franzke commented on patch set 3 CR +1 V +1 05/04/26, 08:27
_kbd.scss:13ReplyDone -
core-ci voted on patch set 2 V +1 05/04/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101455
-
core-ci voted on patch set 3 V +1 05/04/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101456
-
Andreas Kienast commented on patch set 3 CR -1 05/04/26, 11:41
_kbd.scss:26Should be `--typo3-kbd-font-family`? -
Benjamin Kott uploaded patch set 4
CR +1V +105/04/26, 11:45 -
Benjamin Kott commented on patch set 4 05/04/26, 11:45
_kbd.scss:26ReplyDone -
Andreas Kienast voted on patch set 4 CR +1 V +1 05/04/26, 11:46
-
core-ci voted on patch set 4 V +1 05/04/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101464
-
Garvin Hicking commented on patch set 4 CR +1 V +1 05/04/26, 12:23
Nice, also seems to work well with "<kbd><kbd>Ctrl</kbd> + <kbd>K</kbd></kbd>" nesting. -
Benjamin Kott voted on patch set 4 CR +2 V +2 05/04/26, 13:06
-
Benjamin Kott merged patch set 5 05/04/26, 13:16