Review main Merged

93872[BUGFIX] Make kbd context aware

Benjamin Kott CR +2 V +2 Normal +111 −1 updated 05/04/26, 13:16

Commit message

The TYPO3 backend was rendering <kbd> elements with Bootstrap's
default treatment, which ignores the design tokens: typography
did not scale with the parent font size, the dark colour scheme
had no dedicated handling, and the markup read more like a code
label than an actual key.

A dedicated style for <kbd> is now provided, built on existing surface,
text and shadow tokens so light/dark theming and font-size scaling are
inherited automatically.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1418

  1. Benjamin Kott uploaded patch set 1 04/28/26, 10:43

  2. core-ci voted on patch set 1 V +1 04/28/26, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101209

  3. Riccardo De Contardi commented on patch set 1 V +1 04/29/26, 08:55

    tested on latest main 15.0.0
  4. Georg Ringer voted on patch set 1 CR +1 V +1 04/29/26, 19:36

  5. Benjamin Franzke commented on patch set 1 04/30/26, 08:10

    _kbd.scss:13

    This mixes a lighter color than the background in dark mode and therefore creates a glow instead of a shadow (that is generated in light mode). I suggest a dark shadow instead of a light glow in dark-mode, some value like `#181818`
  6. Benjamin Kott uploaded patch set 2 CR +1 V +1 05/04/26, 08:21

  7. Benjamin Kott uploaded patch set 3 05/04/26, 08:27

  8. Benjamin Franzke commented on patch set 3 CR +1 V +1 05/04/26, 08:27

    _kbd.scss:13 Reply

    Done
  9. core-ci voted on patch set 2 V +1 05/04/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101455

  10. core-ci voted on patch set 3 V +1 05/04/26, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101456

  11. Andreas Kienast commented on patch set 3 CR -1 05/04/26, 11:41

    _kbd.scss:26

    Should be `--typo3-kbd-font-family`?
  12. Benjamin Kott uploaded patch set 4 CR +1 V +1 05/04/26, 11:45

  13. Benjamin Kott commented on patch set 4 05/04/26, 11:45

    _kbd.scss:26 Reply

    Done
  14. Andreas Kienast voted on patch set 4 CR +1 V +1 05/04/26, 11:46

  15. core-ci voted on patch set 4 V +1 05/04/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101464

  16. Garvin Hicking commented on patch set 4 CR +1 V +1 05/04/26, 12:23

    Nice, also seems to work well with "<kbd><kbd>Ctrl</kbd> + <kbd>K</kbd></kbd>" nesting.
  17. Benjamin Kott voted on patch set 4 CR +2 V +2 05/04/26, 13:06

  18. Benjamin Kott merged patch set 5 05/04/26, 13:16