93877[TASK] Update phpstan to 2.1.54
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 6
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Classes/DependencyInjection/ServiceProviderCompilationPass.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+5 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php5+14 −5
- composer.json+1 −1
- composer.lock+5 −5
Review log 2131
Show 46 earlier messages
-
Anja Leichsenring uploaded patch set 1 04/29/26, 04:13
-
core-ci voted on patch set 1 V -1 04/29/26, 04:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101234
-
Markus Klein uploaded patch set 2
V -104/29/26, 05:58 -
Markus Klein uploaded patch set 3 04/29/26, 06:08
-
core-ci voted on patch set 3 V -1 04/29/26, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101242
-
Markus Klein uploaded patch set 4
V -104/29/26, 06:18
-
core-ci voted on patch set 4 V +1 04/29/26, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101243
-
core-ci voted on patch set 2 V -1 04/29/26, 06:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101241
-
Anja Leichsenring updated the commit message in patch set 5
V +104/29/26, 07:43 -
Anja Leichsenring commented on patch set 5 CR +1 V +1 04/29/26, 07:43
Markus did all the work, so I vote here. Thank you for helping out. -
core-ci voted on patch set 5 V +1 04/29/26, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101246
-
core-ci commented on patch set 5 04/29/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101247
-
Markus Klein voted on patch set 5 CR +1 V +1 04/29/26, 08:06
-
Oliver Klee voted on patch set 5 CR +1 V +1 04/29/26, 08:36
-
Anja Leichsenring uploaded patch set 6
CR +1V +104/30/26, 03:53 -
core-ci voted on patch set 6 V +1 04/30/26, 04:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101292
-
core-ci commented on patch set 6 04/30/26, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101293
-
Garvin Hicking commented on patch set 6 04/30/26, 05:29
PageLinkBuilder.php:680Should this better be a null-check instead of dynamic false casting? -
Oliver Klee voted on patch set 6 V +1 04/30/26, 06:27
-
Stefan Bürk commented on patch set 6 04/30/26, 06:30
PageLinkBuilder.php:680ReplyIn that case I would more go with a negated instanceof check because any thing before **possibly** may set/change that information - alt least it is not ensured at this place I'd say. -
Oliver Klee commented on patch set 6 04/30/26, 06:34
PageLinkBuilder.php:692Then we should also change this: ```suggestion if (!is_array($localRootLine)) { ``` -
Christian Kuhn updated the commit message in patch set 7
V +105/02/26, 09:35 -
Christian Kuhn commented on patch set 7 05/02/26, 09:50
PageLinkBuilder.php:680ReplyDonePageLinkBuilder.php:692Reply`getLocalRootline(): array`, we can go with `=== []`. -
Christian Kuhn uploaded patch set 8 05/02/26, 09:51
-
core-ci voted on patch set 8 V +1 05/02/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101383
-
Christian Kuhn voted on patch set 8 CR +1 V +1 05/02/26, 10:11
-
core-ci voted on patch set 7 V +1 05/02/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101380
-
Oliver Klee voted on patch set 8 CR +1 V +1 05/02/26, 10:16
-
Stefan Bürk voted on patch set 8 CR +1 V +1 05/02/26, 10:18
-
Christian Kuhn voted on patch set 8 CR +2 V +2 05/02/26, 10:19
-
Christian Kuhn merged patch set 9 05/02/26, 10:28