Review main Merged

93877[TASK] Update phpstan to 2.1.54

Anja Leichsenring CR +2 V +2 Easy +26 −19 updated 05/02/26, 10:28

Commit message

The new version causes new errors detected, what warrants the update
of the minimum version and fixing of messages.

Used commands:

> Build/Scripts/runTests.sh -s composer \
    -- require --dev phpstan/phpstan:^2.1.54

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2131

Show 46 earlier messages
  1. Anja Leichsenring uploaded patch set 1 04/29/26, 04:13

  2. core-ci voted on patch set 1 V -1 04/29/26, 04:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101234

  3. Markus Klein uploaded patch set 2 V -1 04/29/26, 05:58

  4. Markus Klein uploaded patch set 3 04/29/26, 06:08

  5. core-ci voted on patch set 3 V -1 04/29/26, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101242

  6. Markus Klein uploaded patch set 4 V -1 04/29/26, 06:18

  1. core-ci voted on patch set 4 V +1 04/29/26, 06:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101243

  2. core-ci voted on patch set 2 V -1 04/29/26, 06:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101241

  3. Anja Leichsenring updated the commit message in patch set 5 V +1 04/29/26, 07:43

  4. Anja Leichsenring commented on patch set 5 CR +1 V +1 04/29/26, 07:43

    Markus did all the work, so I vote here. Thank you for helping out.
  5. core-ci voted on patch set 5 V +1 04/29/26, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101246

  6. core-ci commented on patch set 5 04/29/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101247

  7. Markus Klein voted on patch set 5 CR +1 V +1 04/29/26, 08:06

  8. Oliver Klee voted on patch set 5 CR +1 V +1 04/29/26, 08:36

  9. Anja Leichsenring uploaded patch set 6 CR +1 V +1 04/30/26, 03:53

  10. core-ci voted on patch set 6 V +1 04/30/26, 04:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101292

  11. core-ci commented on patch set 6 04/30/26, 04:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101293

  12. Garvin Hicking commented on patch set 6 04/30/26, 05:29

    PageLinkBuilder.php:680

    Should this better be a null-check instead of dynamic false casting?
  13. Oliver Klee voted on patch set 6 V +1 04/30/26, 06:27

  14. Stefan Bürk commented on patch set 6 04/30/26, 06:30

    PageLinkBuilder.php:680 Reply

    In that case I would more go with a negated instanceof check because any thing before **possibly** may set/change that information - alt least it is not ensured at this place I'd say.
  15. Oliver Klee commented on patch set 6 04/30/26, 06:34

    PageLinkBuilder.php:692

    Then we should also change this: ```suggestion if (!is_array($localRootLine)) { ```
  16. Christian Kuhn updated the commit message in patch set 7 V +1 05/02/26, 09:35

  17. Christian Kuhn commented on patch set 7 05/02/26, 09:50

    PageLinkBuilder.php:680 Reply

    Done

    PageLinkBuilder.php:692 Reply

    `getLocalRootline(): array`, we can go with `=== []`.
  18. Christian Kuhn uploaded patch set 8 05/02/26, 09:51

  19. core-ci voted on patch set 8 V +1 05/02/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101383

  20. Christian Kuhn voted on patch set 8 CR +1 V +1 05/02/26, 10:11

  21. core-ci voted on patch set 7 V +1 05/02/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101380

  22. Oliver Klee voted on patch set 8 CR +1 V +1 05/02/26, 10:16

  23. Stefan Bürk voted on patch set 8 CR +1 V +1 05/02/26, 10:18

  24. Christian Kuhn voted on patch set 8 CR +2 V +2 05/02/26, 10:19

  25. Christian Kuhn merged patch set 9 05/02/26, 10:28