Review main Merged

93878[BUGFIX] Make asset:publish during `composer install` more resilient

Helmut Hummel CR +2 V +2 Easy +28 −5 updated 05/02/26, 10:50

Commit message

Since the command is run automatically on composer install,
we need to make sure that the composer build process does not
abort, since a failure of this command does not contradict
the composer build, but is rather performed as automation.

For that the command itself slightly changed to only output
the full exception message with increased verbosity.

The ConsoleCommand execution now catches the failure,
outputs error messages according to the used verbosity
but ensure that Composer build process can finish successfully.

The error output should be clear enough to know that something
went wrong.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 912

  1. Helmut Hummel uploaded patch set 1 04/29/26, 10:52

  2. core-ci voted on patch set 1 V +1 04/29/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101260

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/29/26, 11:43

  4. Oliver Klee updated the commit message in patch set 3 04/29/26, 11:43

  5. Oliver Klee voted on patch set 3 CR +1 04/29/26, 11:43

  6. core-ci voted on patch set 2 V +1 04/29/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101263

  7. core-ci voted on patch set 3 V +1 04/29/26, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101264

  8. Garvin Hicking voted on patch set 3 CR +1 04/29/26, 15:56

  9. Markus Klein commented on patch set 3 04/30/26, 08:57

    CommandExecutionFailedException.php:28

    why not PHP_EOL?
  10. Benni Mack commented on patch set 3 CR +1 V +1 04/30/26, 12:29

    CommandExecutionFailedException.php:28 Reply

    we have no rule (yet) when to use what
  11. Christian Kuhn commented on patch set 3 CR +2 V +2 05/02/26, 10:38

    CommandExecutionFailedException.php:28 Reply

    Done
  12. Christian Kuhn merged patch set 4 05/02/26, 10:50