Review main Merged

93881[BUGFIX] Relax size constraints of page creation wizard and livesearch

Benjamin Kott CR +2 V +2 Hard +262 −30 updated 05/07/26, 15:14

Commit message

Both the page creation wizard and the global live search opened
in modals using the `medium` preset (800x520) which is wider than
tall — a poor fit for content that grows vertically. They now use
a taller configuration that matches the way their content is
actually laid out.

Rather than adding further named presets for these specific use
cases, the modal API gains a composable `SizeConfig` shape that
lets callers pick per-axis size tokens. The existing preset enum
remains unchanged and no existing call site needs to migrate.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2127

Show 12 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/29/26, 13:14

  2. core-ci voted on patch set 1 V +1 04/29/26, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101273

  1. Garvin Hicking commented on patch set 1 04/29/26, 17:30

    Important-109731-ModalApiSizeConfiguration.rst:1

    this file would need to go into the 14.3.x directory instead.
  2. Benjamin Kott uploaded patch set 2 V +1 05/04/26, 07:40

  3. Benjamin Kott commented on patch set 2 05/04/26, 07:41

    Important-109731-ModalApiSizeConfiguration.rst:1 Reply

    Done
  4. core-ci voted on patch set 2 V +1 05/04/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101454

  5. Benjamin Kott uploaded patch set 3 V +1 05/04/26, 09:36

  6. core-ci voted on patch set 3 V +1 05/04/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101459

  7. Andreas Kienast voted on patch set 3 CR +1 V +1 05/04/26, 11:54

  8. Benjamin Franzke commented on patch set 3 05/04/26, 14:05

    modal.ts:149

    We could avoid this fail-first try-catch by first checking if the value is a valid string, and require a valid JSON afterwards.

    modal.ts:193

    Shouldn't this be handled by the `toAttribute` converter + `reflect:true`? Seems redundant to me
  9. Benjamin Franzke uploaded patch set 4 CR +1 V +1 05/04/26, 14:17

  10. Benjamin Franzke commented on patch set 4 05/04/26, 14:17

    modal.ts:149 Reply

    Done

    modal.ts:193 Reply

    Done
  11. core-ci voted on patch set 4 V +1 05/04/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101470

  12. Benjamin Franzke voted on patch set 4 CR 0 V 0 05/04/26, 15:19

  13. Benjamin Kott uploaded patch set 5 V +1 05/04/26, 15:27

  14. core-ci voted on patch set 5 V +1 05/04/26, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101474

  15. Benjamin Franzke uploaded patch set 6 V +1 05/04/26, 15:41

  16. core-ci voted on patch set 6 V +1 05/04/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101475

  17. Josua Vogel commented on patch set 6 05/07/26, 11:48

    modal.ts:49

    I don't think it's ideal that we now have Size, Sizes, and SizeConfig. In my opinion, it's a bit confusing.

    modal.ts:175

    When the size attribute is set to a JSON string (e.g. '{"width":"invalid"}'), the first isValidSize(value) call correctly rejects it (it's a plain string, not a valid Sizes key). JSON.parse then produces an object that is returned without passing it through isValidSize again. The setter will normalise it to Sizes.default as a safety net, but the converter's contract is broken — it should always return a value of the declared property type Like this: try { const parsed = JSON.parse(value); return isValidSize(parsed) ? parsed : Sizes.default; } catch { return Sizes.default; }
  18. Josua Vogel commented on patch set 6 05/07/26, 11:51

    @benjamin.kott@outlook.com Otherwise, I think the new modal format is much better. Thanks so much for the fix!
  19. Benjamin Kott commented on patch set 6 05/07/26, 12:10

    modal.ts:49 Reply

    i agree, we already have "sizes" that are more like "presets" - but it not really worth the effort for a rename and the complications for extensions it provides, it´s definitely not optimal but better than the alternatives

    modal.ts:175 Reply

    not sure if i can follow, it never reaches the JSON.parse if it's not valid in the first place, can you help me out where it behaves incorrectly we tested - all kinds of attribute modifications - all kinds of property settings
  20. Josua Vogel commented on patch set 6 05/07/26, 12:24

    modal.ts:49 Reply

    yes, I understand this. Just wanted to mention this, but it´s fine for me
  21. Josua Vogel commented on patch set 6 05/07/26, 13:17

    modal.ts:175 Reply

    It's more of a cosmetic change; fundamentally, it works. Currently, `fromAttribute` returns `{width: ‘invalid’}`. The setter then ensures that `Sizes.default` is used. In my opinion, it would be better to ensure directly in `fromAttribute` that a valid `Sizes` value is returned.
  22. Benjamin Kott commented on patch set 6 05/07/26, 13:27

    modal.ts:175 Reply

    @ben@bnf.dev wanted to have an early return here, everything runs through set size anyways, technically we can skip the checks in the attribute converter and only check null, parse json or return the string, "set size" will handle the validation and fallbacks.
  23. Josua Vogel commented on patch set 6 CR +1 V +1 05/07/26, 13:28

    modal.ts:175 Reply

    Acknowledged
  24. Benjamin Kott voted on patch set 6 CR +2 V +2 05/07/26, 14:50

  25. Benjamin Kott merged patch set 7 05/07/26, 15:14