93881[BUGFIX] Relax size constraints of page creation wizard and livesearch
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Josua Vogel +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/Sass/component/_modal.scss+45 −12
- Build/Sources/TypeScript/backend/live-search/live-search.ts+2 −2
- Build/Sources/TypeScript/backend/page-wizard/helper/wizard-helper.ts+5 −2
- Build/Sources/TypeScript/backend/modal.ts12+79 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+18 −7
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/live-search.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/helper/wizard-helper.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-109731-ModalApiSizeConfiguration.rstnew+65 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Modal.fluid.html+33 −0
Review log 2127
Show 12 earlier messages
-
Benjamin Kott uploaded patch set 1 04/29/26, 13:14
-
core-ci voted on patch set 1 V +1 04/29/26, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101273
-
Garvin Hicking commented on patch set 1 04/29/26, 17:30
-
Benjamin Kott uploaded patch set 2
V +105/04/26, 07:40 -
Benjamin Kott commented on patch set 2 05/04/26, 07:41
Important-109731-ModalApiSizeConfiguration.rst:1ReplyDone -
core-ci voted on patch set 2 V +1 05/04/26, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101454
-
Benjamin Kott uploaded patch set 3
V +105/04/26, 09:36 -
core-ci voted on patch set 3 V +1 05/04/26, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101459
-
Andreas Kienast voted on patch set 3 CR +1 V +1 05/04/26, 11:54
-
Benjamin Franzke commented on patch set 3 05/04/26, 14:05
modal.ts:149We could avoid this fail-first try-catch by first checking if the value is a valid string, and require a valid JSON afterwards.modal.ts:193Shouldn't this be handled by the `toAttribute` converter + `reflect:true`? Seems redundant to me -
Benjamin Franzke uploaded patch set 4
CR +1V +105/04/26, 14:17 -
Benjamin Franzke commented on patch set 4 05/04/26, 14:17
modal.ts:149ReplyDonemodal.ts:193ReplyDone -
core-ci voted on patch set 4 V +1 05/04/26, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101470
-
Benjamin Franzke voted on patch set 4 CR 0 V 0 05/04/26, 15:19
-
Benjamin Kott uploaded patch set 5
V +105/04/26, 15:27 -
core-ci voted on patch set 5 V +1 05/04/26, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101474
-
Benjamin Franzke uploaded patch set 6
V +105/04/26, 15:41 -
core-ci voted on patch set 6 V +1 05/04/26, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101475
-
Josua Vogel commented on patch set 6 05/07/26, 11:48
modal.ts:49I don't think it's ideal that we now have Size, Sizes, and SizeConfig. In my opinion, it's a bit confusing.modal.ts:175When the size attribute is set to a JSON string (e.g. '{"width":"invalid"}'), the first isValidSize(value) call correctly rejects it (it's a plain string, not a valid Sizes key). JSON.parse then produces an object that is returned without passing it through isValidSize again. The setter will normalise it to Sizes.default as a safety net, but the converter's contract is broken — it should always return a value of the declared property type Like this: try { const parsed = JSON.parse(value); return isValidSize(parsed) ? parsed : Sizes.default; } catch { return Sizes.default; } -
Josua Vogel commented on patch set 6 05/07/26, 11:51
@benjamin.kott@outlook.com Otherwise, I think the new modal format is much better. Thanks so much for the fix! -
Benjamin Kott commented on patch set 6 05/07/26, 12:10
modal.ts:49Replyi agree, we already have "sizes" that are more like "presets" - but it not really worth the effort for a rename and the complications for extensions it provides, it´s definitely not optimal but better than the alternativesmodal.ts:175Replynot sure if i can follow, it never reaches the JSON.parse if it's not valid in the first place, can you help me out where it behaves incorrectly we tested - all kinds of attribute modifications - all kinds of property settings -
Josua Vogel commented on patch set 6 05/07/26, 12:24
modal.ts:49Replyyes, I understand this. Just wanted to mention this, but it´s fine for me -
Josua Vogel commented on patch set 6 05/07/26, 13:17
modal.ts:175ReplyIt's more of a cosmetic change; fundamentally, it works. Currently, `fromAttribute` returns `{width: ‘invalid’}`. The setter then ensures that `Sizes.default` is used. In my opinion, it would be better to ensure directly in `fromAttribute` that a valid `Sizes` value is returned. -
Benjamin Kott commented on patch set 6 05/07/26, 13:27
modal.ts:175Reply@ben@bnf.dev wanted to have an early return here, everything runs through set size anyways, technically we can skip the checks in the attribute converter and only check null, parse json or return the string, "set size" will handle the validation and fallbacks. -
Josua Vogel commented on patch set 6 CR +1 V +1 05/07/26, 13:28
modal.ts:175ReplyAcknowledged -
Benjamin Kott voted on patch set 6 CR +2 V +2 05/07/26, 14:50
-
Benjamin Kott merged patch set 7 05/07/26, 15:14
Important-109731-ModalApiSizeConfiguration.rst:1