Review main Merged

93895[DOCS] Update RST for extbase #[Authorize] attribute

Torben Hansen CR +2 V +2 Easy +6 −1 updated 05/01/26, 13:55

Commit message

The changelog entry for feature #107826 does not mention
that a custom authorization class used as a callback in
the `#[Authorize]` attribute must be declared as public
in the DI container.

This change updates the "Custom authorization class"
section to use `#[Autoconfigure(public: true)]` on the
authorization class and mention this requirement in the
description.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Torben Hansen uploaded patch set 1 05/01/26, 09:28

  2. core-ci voted on patch set 1 V +1 05/01/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101356

  3. Oliver Klee voted on patch set 1 CR +1 V +1 05/01/26, 09:39

  4. Garvin Hicking commented on patch set 1 05/01/26, 09:57

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:147

    We could also promote the `#[Autoconfigure(public:true)` in a class instead, which should work too?!
  5. Torben Hansen uploaded patch set 2 CR +1 V +1 05/01/26, 10:35

  6. Torben Hansen commented on patch set 2 05/01/26, 10:35

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:147 Reply

    Good catch. I adapted the RST
  7. Torben Hansen commented on patch set 3 05/01/26, 10:41

    Published edit on patch set 2.
  8. core-ci voted on patch set 2 V +1 05/01/26, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101358

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 05/01/26, 10:48

    Feature-107826-IntroduceExtbaseActionAuthorizationLogic.rst:147 Reply

    Thanks, works for me 😊
  10. core-ci voted on patch set 3 V -1 05/01/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101359

  11. Oliver Klee voted on patch set 3 CR +1 V +1 05/01/26, 11:00

  12. core-ci voted on patch set 3 V +1 05/01/26, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101359

  13. Garvin Hicking voted on patch set 3 CR +2 V +2 05/01/26, 12:44

  14. Garvin Hicking merged patch set 4 05/01/26, 13:55