Review main Abandoned

93896[TASK] Fix SameSite=None handling and ensure correct cookie removal attrib

TYPO3com CR 0 V -1 Normal +91 −5 updated 10/06/26, 16:00

Commit message

This patch fixes incorrect handling of cookie attributes in the core HTTP
cookie service, ensuring valid SameSite behavior and consistent cookie
removal.

SameSite=None cookies require the Secure flag and must only be used over
HTTPS.
The previous implementation could force the Secure flag even on non-HTTPS
requests, resulting in cookies being ignored by browsers.

This patch ensures:
- SameSite=None is only used on HTTPS requests
- fallback to SameSite=Strict on non-HTTPS requests
- Secure flag is only set when the request is HTTPS

Cookie removal did not consistently preserve important attributes such
as:
- domain / hostOnly
- Secure flag
- HttpOnly flag
- SameSite policy

Since browsers require exact attribute matching for deletion, this could
result in cookies not being removed properly.

This patch ensures cookie removal uses consistent attributes, preventing
stale cookies.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 2

Review log 13

  1. TYPO3com uploaded patch set 1 05/01/26, 09:32

  2. core-ci voted on patch set 1 V -1 05/01/26, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101357

  3. Georg Ringer abandoned the change 10/06/26, 16:00

    abandoned, see issue