Review main Merged

93897[BUGFIX] Translate nested item descriptions

Ravi Sachaniya CR +2 V +2 Normal +53 −1 updated 11/13/26, 09:28

Commit message

Resolve item description labels when descriptions are given as an
array with "title" and "description" entries for
TCA type `selectCheckBox`

This keeps localized help text handling consistent with string-based
descriptions and the expected selectCheckBox item structure

The styleguide shows the array notation with translated labels: item
"foo 1" of field "select_checkbox_3" in the table "Form engine -
select", tab "renderType=selectCheckBox".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1319

  1. Ravi Sachaniya uploaded patch set 1 05/01/26, 11:54

  2. core-ci voted on patch set 1 V -1 05/01/26, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101360

  3. Ravi Sachaniya updated the commit message in patch set 2 V -1 05/06/26, 04:44

  4. core-ci voted on patch set 2 V +1 05/06/26, 04:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101591

  5. Mathias Brodala commented on patch set 2 05/06/26, 05:40

    AbstractItemProvider.php:1184

    This should be simplfied: $helpText = [ 'title' => ..., 'description' => ..., ];
  6. Ravi Sachaniya uploaded patch set 3 V +1 05/06/26, 05:45

  7. Ravi Sachaniya commented on patch set 3 05/06/26, 05:46

    AbstractItemProvider.php:1184 Reply

    done
  8. core-ci voted on patch set 3 V +1 05/06/26, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101594

  9. Ravi Sachaniya uploaded patch set 4 V +1 07/09/26, 11:04

  10. core-ci voted on patch set 4 V +1 07/09/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104563

  11. Ravi Sachaniya uploaded patch set 5 07/09/26, 11:23

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  12. core-ci voted on patch set 5 V +1 07/09/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104565

  13. Georg Ringer uploaded patch set 6 V +1 11/09/26, 21:30

  14. Benni Mack voted on patch set 6 CR +1 V +1 11/09/26, 21:31

  15. core-ci voted on patch set 6 V +1 11/09/26, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113802

  16. Ravi Sachaniya voted on patch set 6 CR +1 V +1 11/13/26, 04:52

  17. Josua Vogel voted on patch set 6 CR +1 V +1 11/13/26, 07:03

  18. Benni Mack voted on patch set 6 CR +2 V +2 11/13/26, 09:28

  19. Benni Mack merged patch set 7 11/13/26, 09:28