Review 14.3 Merged

93904[BUGFIX] Cast group identifier to string in foreach key variable

Christian Kuhn CR +2 V +2 Easy +48 −0 updated 05/02/26, 10:50

Commit message

If a group identifier is defined as a numeric string like "2026", then
this will be converted to an integer key for PHP array `$itemGroups`.
Therefore the key must be cast to a string or else strict type checking
will fail for object `SelectItem`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 05/02/26, 10:33

  2. core-ci voted on patch set 1 V +1 05/02/26, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101389

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/02/26, 10:50

  4. Christian Kuhn merged patch set 2 05/02/26, 10:50