Review 14.3 Merged

93913[TASK] Allow translated labels in TCA "color" elements

Christian Kuhn CR +2 V +2 Hard +267 −8 updated 05/02/26, 16:55

Commit message

With the introduction of Alwan for the TCA color type,
the valuePicker items are migrated to swatches on the fly.

However, the label was only passed through as-is. This patch
adds languageService calls to resolve the labels and unifies
output to "label (#RRGGBB)" including fallback for null
or empty values.

Missing tests for the output of this element are now added,
covering the changed behavior.

Examples are added to EXT:styleguide to show that fallbacks
are also utilized. EXT:scheduler task group color swatches
actually also revealed the broken behavior.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 34

  1. Christian Kuhn commented on patch set 1 05/02/26, 15:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 05/02/26, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101401

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/02/26, 16:55

  4. Christian Kuhn merged patch set 2 05/02/26, 16:55