Review main Merged

93938[BUGFIX] Resolve content areas during iteration

Matthias Vogel CR +2 V +2 Easy +6 −2 updated 05/05/26, 16:06

Commit message

Consumers expect iterable content area collections to expose ContentArea
instances. Build the iterator result through get() so lazy
ContentAreaClosure instances are resolved with the stored request before
callers access content area APIs.

Also give the request object to the new instance in withUpdatedRecords.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Matthias Vogel uploaded patch set 1 05/04/26, 09:06

  2. Matthias Vogel uploaded patch set 2 05/04/26, 09:08

  3. Matthias Vogel marked it ready for review 05/04/26, 09:11

  4. core-ci voted on patch set 1 V -1 05/04/26, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101457

  5. core-ci voted on patch set 2 V +1 05/04/26, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101458

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 05/04/26, 09:26

  7. Georg Ringer voted on patch set 2 CR +1 V +1 05/05/26, 03:04

  8. Josua Vogel voted on patch set 2 CR +1 V +1 05/05/26, 06:59

  9. Simon Praetorius voted on patch set 2 CR +2 V +2 05/05/26, 15:57

  10. Simon Praetorius merged patch set 3 05/05/26, 16:06