Review main Merged

93943[TASK] Migrate further codeception tests to playwright

Christian Kuhn CR +2 V +2 Hard +358 −560 updated 05/04/26, 16:07

Commit message

The patch migrates further codeception cests to playwright
specs, mainly general single module functionality.

As always with such tests, we'll have to see if they are
stable over time, and will adapt if necessary.

Drive-by: e2e/records/sys-note.spec.ts had a flaky assertion
on .note-body via .first() that depended on DOM order. Filter
by hasText() now.

Drive-by: e2e/layout/open-in-new-window-language-switching.spec.ts
hit the 30s test timeout because the typo3-module-loaded event
does not always bubble out of the modal-driven navigation. This
next attempt waits at 3s and lets the auto-waiting expect() on
the loaded form act as the real signal.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1017

  1. Christian Kuhn uploaded patch set 1 05/04/26, 13:38

  2. core-ci voted on patch set 1 V +1 05/04/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101467

  3. Christian Kuhn uploaded patch set 2 V +1 05/04/26, 14:06

  4. core-ci voted on patch set 2 V -1 05/04/26, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101469

  5. Christian Kuhn uploaded patch set 3 V -1 05/04/26, 14:29

  6. core-ci voted on patch set 3 V +1 05/04/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101471

  7. Christian Kuhn uploaded patch set 4 V +1 05/04/26, 14:49

  8. core-ci voted on patch set 4 V -1 05/04/26, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101472

  9. core-ci voted on patch set 4 V +1 05/04/26, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101472

  10. Christian Kuhn updated the commit message in patch set 5 V +1 05/04/26, 15:14

  11. core-ci voted on patch set 5 V -1 05/04/26, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101473

  12. core-ci voted on patch set 5 V +1 05/04/26, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101473

  13. Oliver Klee voted on patch set 5 V +1 05/04/26, 15:39

  14. Stefan Bürk voted on patch set 5 CR +1 05/04/26, 15:44

  15. Oliver Klee voted on patch set 5 CR +1 05/04/26, 15:48

  16. Stefan Bürk voted on patch set 5 CR +2 V +2 05/04/26, 15:54

  17. Stefan Bürk merged patch set 6 05/04/26, 16:07