93946[TASK] Replace unsafe rand() with random_int() in UserSessionManager
Commit message
Review
-
Code review CR -1
- Mathias Brodala -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 46
-
TYPO3com uploaded patch set 1 05/04/26, 15:56
-
core-ci voted on patch set 1 V +1 05/04/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101478
-
Christian Kuhn commented on patch set 1 CR -1 05/04/26, 16:19
-
Mathias Brodala commented on patch set 1 CR -1 05/06/26, 05:11
Unresolved
AFAIS this is an AI generated suggestion, the wording sounds quite artificial and unnecessarily verbose. Also the author https://github.com/jmestwa-coder only started coding on Github in March and has already created PRs in many completely unrelated repositories. And I agree with lolli, the broader context (session management) may be security-relevant but the actual context (garbage collection) is not, so an "unsecure" randomness is fine. -
Christian Kuhn wrote 06/18/26, 23:11
Removed reviewer Christian Kuhn with the following votes: * Code-Review-1 by Christian Kuhn -
Garvin Hicking abandoned the change 08/06/26, 15:59
Unresolved