93947[TASK] Replace predictable uniqid() calls with StringUtility::getUniqueId(
Commit message
Review
-
Code review CR -1
- Oliver Hader -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 3
Review log 46
-
TYPO3com uploaded patch set 1 05/04/26, 16:06
-
core-ci voted on patch set 1 V +1 05/04/26, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101480
-
Christian Kuhn commented on patch set 1 CR -1 05/04/26, 16:26
imho NACK as well: the call sites don't need cryptographic randomness - uniqid is only needed to have something unique within the same rendered page.Unresolved
StringUtility::getUniqueId() delegates to uniqid(), not random_bytes(). -
Oliver Hader commented on patch set 1 CR -1 05/05/26, 05:20
`StringUtility::getUniqueId` does not use `random_bytes` but only an internal cheap CLCG. There is no security impact for these usages in the markup. -
Christian Kuhn wrote 06/18/26, 23:11
Removed reviewer Christian Kuhn with the following votes: * Code-Review-1 by Christian Kuhn -
Georg Ringer abandoned the change 10/06/26, 15:51