Review main Merged

93955[TASK] Drop codeception ext:impexp non-admin tests

Christian Kuhn CR +2 V +2 Hard +0 −298 updated 05/05/26, 08:51

Commit message

Remove UsersCest from the codeception Application tests:
The test only verifies if context menu related entries
are shown respecting admin/non-admin flags.

The underlying authorization decision lives in
BackendUserAuthentication::isImportEnabled() and is covered by
functional tests. The impexp ContextMenu/ItemProvider is a thin
delegate to those methods, munging such gates should pop up in
any review easily and removing these e2e tests saves us from
migration and potential flakiness.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 05/04/26, 22:31

  2. core-ci voted on patch set 1 V -1 05/04/26, 22:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101504

  3. core-ci voted on patch set 1 V +1 05/04/26, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101504

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 05/04/26, 23:39

  5. Josua Vogel voted on patch set 1 CR +1 V +1 05/05/26, 06:17

  6. Oliver Klee voted on patch set 1 CR +1 V +1 05/05/26, 07:16

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 05/05/26, 08:23

  8. Christian Kuhn merged patch set 2 05/05/26, 08:51