Review main Merged

93973[BUGFIX] Skip foreign table query for transOrigPointerField on default language

Benni Mack CR +2 V +2 Easy +13 −1 updated 09/02/26, 07:56

Commit message

The transOrigPointerField (e.g. l18n_parent) is configured with a
displayCond that hides it for records in the default language
(sys_language_uid <= 0). However, TcaSelectItems runs before
EvaluateDisplayConditions and unconditionally calls
addItemsFromForeignTable(), which queries all records on the same
PID. On pages with large numbers of content records this causes
significant performance degradation.

Skip the addItemsFromForeignTable() call when the field being
processed is the transOrigPointerField and the current record
belongs to the default or "all languages" language, as the field
will never be displayed in that case.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Markus Klein +1
    • Stefan Bürk +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • Sascha Nowak +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Benni Mack uploaded patch set 1 05/05/26, 07:22

  2. core-ci voted on patch set 1 V +1 05/05/26, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101528

  3. Markus Klein voted on patch set 1 CR +1 05/05/26, 07:43

  4. Benni Mack marked it ready for review 05/05/26, 12:05

  5. Georg Ringer voted on patch set 1 CR +1 V +1 09/02/26, 05:45

  6. Josua Vogel voted on patch set 1 CR +1 09/02/26, 05:51

  7. Ravi Sachaniya voted on patch set 1 CR +1 09/02/26, 05:54

  8. Sascha Nowak voted on patch set 1 CR +1 09/02/26, 06:35

  9. Stefan Bürk voted on patch set 1 CR +1 V +1 09/02/26, 07:55

  10. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 07:56

  11. Benni Mack merged patch set 2 09/02/26, 07:56