Review main Abandoned

93974[BUGFIX] Generate unique dashboard identifiers

TYPO3com CR -1 V -1 Easy +46 −1 updated 10/09/26, 08:54

Commit message

The identifier of a new dashboard was built from the preset
identifier and time() only. Two backend users who got a dashboard
from the same preset within the same second, e.g. their default
dashboard on first login, ended up with the same identifier.

As dashboards are updated and deleted by identifier only, renaming,
changing or deleting the dashboard of one user also affected the
dashboard of the other user.

StringUtility::getUniqueId() is now used to build the identifier.

Review

  • Code review CR -1
    • Wouter Wolters -1
  • Verified V -1
    • Wouter Wolters -1
    • core-ci +1 CI

Issues 1

Files 2

Review log 59

  1. TYPO3com uploaded patch set 1 05/05/26, 07:38

  2. core-ci voted on patch set 1 V -1 05/05/26, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101531

  3. Mathias Brodala commented on patch set 1 CR -1 05/06/26, 05:16

    Unresolved

    The explanation about time() usage is bogus: since getUniqueId() is and was used, the resulting identifier was always guaranteed to be unique, even if the time() result was the same due to concurrent requests. Also as mentioned elsewhere: the change is clearly produced by an AI without any real benefit.
  4. Georg Ringer uploaded patch set 2 CR -1 V -1 10/06/26, 15:40

  5. Georg Ringer updated the commit message in patch set 3 10/06/26, 15:41

  6. core-ci voted on patch set 2 V +1 10/06/26, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110232

  7. core-ci voted on patch set 3 V +1 10/06/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110233

  8. Wouter Wolters commented on patch set 3 CR -1 V -1 10/06/26, 15:58

    This PR is not needed IMO. It does not solve anything.
  9. Georg Ringer abandoned the change 10/09/26, 08:54