Review main Merged

93980[TASK] Harden toggleRecordVisibilityAction access checks

Oliver Hader CR +2 V +2 Easy +15 −1 updated 06/05/26, 14:25

Commit message

Adds explicit backend user permission checks to the record
visibility toggle endpoint before delegating to DataHandler:

- Verify tables_modify access for the target table
- Fetch record pid to perform readPageAccess validation
- Skip page access check for root-level records whose
  schema opts out of root-level restrictions

Note: This change is not classified as a security vulnerability,
since DataHandler already enforces authorization on the write
path, and the endpoint exposes no confidential data within
TYPO3's security model.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1418

  1. Oliver Hader uploaded patch set 1 05/05/26, 09:23

  2. core-ci voted on patch set 1 V -1 05/05/26, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101539

  3. core-ci commented on patch set 1 05/05/26, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101539

  4. Oliver Klee voted on patch set 1 CR +1 05/18/26, 07:39

  5. Oliver Klee commented on patch set 1 05/19/26, 12:09

    Probably needs a rebase to get less flaky acceptance tests.
  6. Oliver Hader rebased onto patch set 2 CR +1 V -1 06/04/26, 11:14

  7. core-ci voted on patch set 2 V +1 06/04/26, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102946

  8. Oliver Klee voted on patch set 2 CR +1 V +1 06/04/26, 12:02

  9. Christian Kuhn voted on patch set 2 CR +1 V +1 06/04/26, 17:19

  10. Torben Hansen voted on patch set 2 CR +1 V +1 06/04/26, 17:34

  11. Oliver Hader commented on patch set 2 CR -1 06/05/26, 09:05

    Wait. Seems like 13.4 did not have that route...
  12. Oliver Hader commented on patch set 2 06/05/26, 09:11

    Reply

    Yepp, not required for 13.4.
  13. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 06/05/26, 09:11

  14. core-ci voted on patch set 3 V +1 06/05/26, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103023

  15. Oliver Klee voted on patch set 3 CR +1 V +1 06/05/26, 10:02

  16. Christian Kuhn voted on patch set 3 CR +1 V +1 06/05/26, 10:45

  17. Oliver Hader voted on patch set 3 CR +2 V +2 06/05/26, 14:25

  18. Oliver Hader merged patch set 4 06/05/26, 14:25