93992[BUGFIX] Cleanup fluidAdditionalAttributes when form field is set optional
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 3
Review log 68
-
Josua Vogel uploaded patch set 1 05/05/26, 15:19
-
Josua Vogel updated the commit message in patch set 2 05/05/26, 15:20
-
core-ci voted on patch set 1 V +1 05/05/26, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101561
-
core-ci voted on patch set 2 V +1 05/05/26, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101562
-
Garvin Hicking commented on patch set 2 CR +1 V +1 05/05/26, 21:20
Works for me. Note that my YAML contained: ``` properties: fluidAdditionalAttributes: required: required ``` still, until I added the "required" checkbox (and the "NotEmpty" validator got added) and then removed it again. So just saving the same form will not scrub the unneeded attribute from the YAML. I guess that's not a problem for the YAML parsing though. -
Sven Liebert voted on patch set 2 CR +1 V +1 05/07/26, 05:30
-
Garvin Hicking voted on patch set 2 CR +2 V +2 05/07/26, 06:34
-
Garvin Hicking merged patch set 3 05/07/26, 06:57