93995[BUGFIX] Allow limited markup in form inspector labels and descriptions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2841
Show 1116 earlier messages
-
Josua Vogel uploaded patch set 1 05/05/26, 16:32
-
Josua Vogel updated the commit message in patch set 2 05/05/26, 16:33
-
core-ci voted on patch set 1 V +1 05/05/26, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101569
-
core-ci voted on patch set 2 V -1 05/05/26, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101570
-
core-ci voted on patch set 2 V +1 05/05/26, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101570
-
Garvin Hicking commented on patch set 2 05/05/26, 21:41
-
Josua Vogel uploaded patch set 3
V +105/06/26, 11:45 -
Josua Vogel commented on patch set 3 05/06/26, 11:45
inspector-component.ts:170ReplyDone -
core-ci voted on patch set 3 V +1 05/06/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101614
-
Garvin Hicking commented on patch set 3 05/06/26, 15:47
inspector-component.ts:170ReplyMaybe we can get some feedback if its clever to allow editors to insert p/li there, that could probably break the layout a lot? -
wini2 wini2 voted on patch set 3 V +1 05/06/26, 22:32
-
Josua Vogel commented on patch set 3 05/07/26, 06:24
inspector-component.ts:170ReplyNo, the layout doesn´t break. But I realized, that p, ol ,... aren´t allowed inside label elements. I will split the config. -
Josua Vogel uploaded patch set 4
V +105/07/26, 06:31 -
core-ci voted on patch set 4 V +1 05/07/26, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101650
-
Josua Vogel uploaded patch set 5
V +105/07/26, 07:07 -
Mathias Brodala commented on patch set 4 05/07/26, 07:13
inspector-component.ts:163IMO "a" should not be allowed inside labels. While this kind of works in many browsers it is an a11y issue since labels are triggers for interacting with fields: https://melsumner.github.io/links-labels So this should be removed alongside with the "target" attribute below.
-
core-ci voted on patch set 5 V +1 05/07/26, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101655
-
Josua Vogel commented on patch set 5 05/07/26, 07:32
inspector-component.ts:163ReplyGood point. Thx! If we remove a, then rel and href could be removed too. -
Helmut Hummel commented on patch set 5 05/07/26, 10:17
inspector-component.ts:163Replyif allowing <a href> would also allow <a href="javascript:alert(123)"> I would remove it anyway (even if by default there CSPs are active by default). -
Josua Vogel commented on patch set 5 05/07/26, 11:12
inspector-component.ts:163ReplyNo, javascript:alert(123) would be removed by the sanitizer -
Josua Vogel commented on patch set 5 05/07/26, 11:13
inspector-component.ts:170ReplyDone -
Josua Vogel uploaded patch set 6
V +105/07/26, 11:17 -
Mathias Brodala commented on patch set 6 05/07/26, 11:18
inspector-component.ts:163ReplyDone -
core-ci voted on patch set 6 V +1 05/07/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101676
-
Josua Vogel rebased onto patch set 7
V +105/22/26, 12:08 -
core-ci voted on patch set 7 V +1 05/22/26, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102353
-
Josua Vogel rebased onto patch set 8
V +106/01/26, 14:12 -
core-ci voted on patch set 8 V +1 06/01/26, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102765
-
Josua Vogel rebased onto patch set 9
V +106/24/26, 20:59 -
core-ci voted on patch set 9 V +1 06/24/26, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103835
-
Josua Vogel rebased onto patch set 10
V +107/03/26, 17:02 -
core-ci voted on patch set 10 V +1 07/03/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104321
-
Josua Vogel rebased onto patch set 11
V +107/17/26, 15:07 -
core-ci voted on patch set 11 V +1 07/17/26, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104894
-
Garvin Hicking voted on patch set 11 CR +1 V +1 07/24/26, 15:22
-
Josua Vogel uploaded patch set 12
CR +1V +107/26/26, 12:25 -
core-ci voted on patch set 12 V +1 07/26/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105419
-
Garvin Hicking voted on patch set 12 CR +1 V +1 07/26/26, 12:51
-
Benni Mack voted on patch set 12 CR +1 V +1 07/28/26, 06:21
-
Benni Mack voted on patch set 12 CR +2 V +2 07/28/26, 06:23
-
Benni Mack merged patch set 13 07/28/26, 06:23
inspector-component.ts:170