93998[TASK] Use random_bytes() in StringUtility::getUniqueId()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Utility/StringUtility.php2+2 −4
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+6 −0
- typo3/sysext/styleguide/Classes/ViewHelpers/CodeViewHelper.php2+2 −1
- typo3/sysext/styleguide/Classes/ViewHelpers/ColorSchemeViewHelper.php+1 −1
- typo3/sysext/styleguide/Classes/ViewHelpers/ExampleViewHelper.php2+2 −1
Review log 1115
-
TYPO3com uploaded patch set 1 05/05/26, 22:29
-
core-ci voted on patch set 1 V +1 05/05/26, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101578
-
Oliver Hader commented on patch set 1 05/06/26, 12:36
Code-wise the change is fine and good. However, the description is misleading and might suggest that something was insecure or a vulnerability - which is not the case, since the use-cases do not require cryptographically secure random values. I guess, that we will receive more of these pull-request changing any "insecure" `md5`, `sha1`, `rand_*` usage without considering the corresponding context. Thus: The commit message should be adjusted. Avoid the drama, focus on the facts only.StringUtility.php:61use `12` bytesCodeViewHelper.php:108use namespace importsExampleViewHelper.php:111use namespace imports -
Oliver Hader commented on patch set 1 CR -1 05/06/26, 12:37
see previous comments -
Georg Ringer uploaded patch set 2
CR -1V +110/06/26, 15:55 -
Georg Ringer commented on patch set 2 10/06/26, 15:56
StringUtility.php:61ReplyDoneCodeViewHelper.php:108ReplyDoneExampleViewHelper.php:111ReplyDone -
core-ci voted on patch set 2 V +1 10/06/26, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110236
-
Benni Mack commented on patch set 2 CR +1 10/07/26, 12:01
Reply
Done -
Oliver Klee voted on patch set 2 CR +1 V +1 10/07/26, 12:52
-
Wouter Wolters voted on patch set 2 CR +1 V +1 10/07/26, 15:30
-
Wouter Wolters uploaded patch set 3
CR +1V +110/07/26, 19:36 -
Wouter Wolters voted on patch set 3 CR +1 V +1 10/07/26, 19:36
-
core-ci voted on patch set 3 V +1 10/07/26, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110394
-
Benni Mack voted on patch set 3 CR +2 V +2 10/07/26, 20:05
-
Benni Mack merged patch set 4 10/07/26, 20:05