Review main Merged Breaking

94009[!!!][TASK] Remove GeneralUtility::getIndpEnv()

Christian Kuhn CR +2 V +2 Hard +55 −450 updated 05/15/26, 06:49

Commit message

And adapt remaining last callers as prepared in v14.

Requires a minor testing-framework preparation:

> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 1723

  1. Christian Kuhn uploaded patch set 1 05/06/26, 15:30

  2. core-ci voted on patch set 1 V -1 05/06/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101624

  3. Christian Kuhn uploaded patch set 2 V -1 05/06/26, 15:51

  4. core-ci voted on patch set 2 V +1 05/06/26, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101625

  5. Christian Kuhn updated the commit message in patch set 3 V +1 05/06/26, 16:01

  6. core-ci voted on patch set 3 V +1 05/06/26, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101626

  7. Anja Leichsenring commented on patch set 3 CR +1 V +1 05/06/26, 16:14

    yes!
  8. Oliver Klee voted on patch set 3 CR +1 V +1 05/06/26, 17:28

  9. Christian Kuhn updated the commit message in patch set 4 CR +1 V +1 05/06/26, 17:39

  10. Garvin Hicking updated the commit message in patch set 5 05/06/26, 17:43

  11. core-ci voted on patch set 4 V +1 05/06/26, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101627

  12. Garvin Hicking voted on patch set 5 CR +1 V +1 05/06/26, 17:49

  13. Oliver Klee voted on patch set 5 CR +1 V +1 05/06/26, 17:51

  14. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 05/06/26, 17:53

  15. Oliver Klee voted on patch set 6 CR +1 V +1 05/06/26, 17:54

  16. Garvin Hicking voted on patch set 6 CR +1 V +1 05/06/26, 17:55

  17. core-ci voted on patch set 6 V +1 05/06/26, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101632

  18. core-ci voted on patch set 5 V +1 05/06/26, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101628

  19. Anja Leichsenring voted on patch set 6 CR +1 V +1 05/07/26, 08:12

  20. Christian Kuhn voted on patch set 6 CR +2 V +2 05/07/26, 08:16

  21. Christian Kuhn merged patch set 7 05/07/26, 08:16

  22. Lina Wolf commented on patch set 7 05/14/26, 07:29

    Has the TypoScript option https://docs.typo3.org/permalink/t3tsref:confval-data-getindpenv now also been removed or is it implemented in another way?
  23. Garvin Hicking commented on patch set 7 05/15/26, 06:49

    Reply

    The TypoScript method remains as is. `typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php` still uses the 'getindpenv' accessor but routes the result through the PSR-7 request object.