94019[TASK] Add files to livesearch results
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Kott +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/Sass/component/_livesearch.scss+39 −0
- Build/Sources/TypeScript/backend/live-search/element/result/item/item.ts+2 −0
- Build/Sources/TypeScript/backend/live-search/element/result/result-detail-container.ts2+14 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/ResultItem.php+21 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −0
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/element/result/result-detail-container.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-109787-AddFilesToLivesearchResults.rst7new+56 −0
- typo3/sysext/filelist/Classes/Search/LiveSearch/FileProvider.phpnew+211 −0
- typo3/sysext/filelist/Configuration/Services.yaml+4 −0
- typo3/sysext/filelist/Resources/Private/Language/locallang.xlf2+18 −0
Review log 1722
-
Benjamin Kott uploaded patch set 1 05/07/26, 10:08
-
core-ci voted on patch set 1 V +1 05/07/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101666
-
Simon Schaufelberger uploaded patch set 2
V +106/29/26, 16:49 -
core-ci voted on patch set 2 V +1 06/29/26, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104049
-
Georg Ringer commented on patch set 2 07/01/26, 20:17
this is really a feature -
Benni Mack commented on patch set 2 07/14/26, 12:19
locallang.xlf:9can we use lower-case "live_search.file_provider.filter_label" -
Benni Mack commented on patch set 2 07/14/26, 17:00
Reply
the old live search had the possibility to also allow sys_file_metadata + sys_file_reference records, so I wouldn't put too much pressure on it. So for me it's either task, bugfix or feature. Ideally, we won't put too much time into this discussion, because I think we should make the search much more prominent and "AI-toolkit-ready" (= becoming more than "just" a search and more flexible) so it will change a lot in the near future hopefully. -
Garvin Hicking commented on patch set 2 07/14/26, 19:42
Reply
just for the record. I would be fine to put this in as either one (bugfix/task/feature). Labelling it a feature opens a can of worms and I'd rather first label the can of worms properly to establish rules, but that process is longer than I want to let this "feature" here rot away. (having said that - couldn't review this patch yet, but looking good)result-detail-container.ts:49Should we ensure labels / values do NOT contain HTML markup? If I read this right it would allow any kind of markup here?Important-109787-AddFilesToLivesearchResults.rst:5```suggestion ==================================================== ```Important-109787-AddFilesToLivesearchResults.rst:7```suggestion ==================================================== ```Important-109787-AddFilesToLivesearchResults.rst:19Have not checked this (please disregard if this is embarassing): Can we have a user-specific UserTSConfig option or so to decide whether to utilize this provider or not? I can imagine huge instances with a large fileadmin in where querying this metadata might mean chewing through a lot of data server-side. -
Benni Mack commented on patch set 2 07/14/26, 22:23
Important-109787-AddFilesToLivesearchResults.rst:19ReplyI suggest we add this later-on, again: We didn't finish a lot of Search-specific things in v14, and I would like to move forward in v15... I really miss ranking tbh for example. If OK, I can write this down for a followup -
Garvin Hicking commented on patch set 2 07/15/26, 06:20
Important-109787-AddFilesToLivesearchResults.rst:19ReplySure, fine by me! -
Benni Mack uploaded patch set 3
V +107/17/26, 14:03 -
Benni Mack commented on patch set 3 07/17/26, 14:06
Important-109787-AddFilesToLivesearchResults.rst:5ReplyDoneImportant-109787-AddFilesToLivesearchResults.rst:7ReplyDonelocallang.xlf:9ReplyDone -
core-ci voted on patch set 3 V +1 07/17/26, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104885
-
Benni Mack commented on patch set 3 07/17/26, 14:45
Reply
I'll label it as a task nowresult-detail-container.ts:49Replyas far as I know, these are Lit child bindings. The template's static HTML is parsed once; interpolated values are inserted as text nodes via document.createTextNode semantics, and never re-parsed. A folder named <img src=x onerror=alert(1)> shows up in the "Location" property as exactly that literal string. Same for the label keys — even if a third-party SearchProviderInterface implementation put markup into addProperty(), it renders as text. -
Benni Mack updated the commit message in patch set 4
V +107/17/26, 14:45 -
core-ci voted on patch set 4 V +1 07/17/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104890
-
Benni Mack rebased onto patch set 5
V +107/24/26, 14:55 -
core-ci voted on patch set 5 V +1 07/24/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105336
-
Garvin Hicking voted on patch set 5 CR +1 V +1 07/24/26, 15:38
-
Benni Mack voted on patch set 5 CR +1 V +1 07/24/26, 15:43
-
Benjamin Kott voted on patch set 5 CR +2 V +2 07/24/26, 15:44
-
Benjamin Kott merged patch set 6 07/24/26, 15:55