Review main Merged

94021[BUGFIX] Set generated encryption key during initial setup

Benjamin Franzke CR +2 V +2 Easy +1 −0 updated 05/11/26, 07:08

Commit message

Since #109460 initial typo3 setup may use EXT:impexp
to load a distribution, which requires the
encryption key to be set for import operations.

When using `bin/typo3 -distribution=theme_camino`,
this import procedure happens within the same
process as the generation of the random key.

Ensure that the encryption key is not just written to
the configuration, but loaded right away.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Oliver Hader +1
    • Benjamin Kott +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Benjamin Franzke uploaded patch set 1 05/07/26, 10:41

  2. Mathias Brodala commented on patch set 1 05/07/26, 10:47

    SetupService.php:207

    Should we instead call $configurationManager->exportConfiguration() instead at the end of this method? This would update the TYPO3_CONF_VARS without duplication.
  3. core-ci voted on patch set 1 V +1 05/07/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101671

  4. Benjamin Franzke commented on patch set 1 05/07/26, 11:48

    SetupService.php:207 Reply

    I guess this will make problems at the moment, since the *entire* configuration is reloaded. Problems that I imagine: * `configurationManager->createLocalConfigurationFromFactoryConfiguration()` generated a configuration based on the factory, which is not *finished* yet, e.g. database details are not set up, while factory configuration set partial databse configuration options. * additional.php is reloaded during setup, which may not be expected by existing installation scripts * more(?) For me that is another change, since this influences installation behavior, instead of fixing the concrete bug.
  5. Helmut Hummel commented on patch set 1 CR +1 V +1 05/07/26, 17:34

    SetupService.php:207 Reply

    > this influences installation behavior, instead of fixing the concrete bug. I have a slightly different view on this topic. I would say this change fixes one symptom, but not the underlying issue (bug). I'm fine with fixing the symptom first, though. > Problems that I imagine The first can not be an issue, as the web installer deals with the same (in different processes, but that should not matter) If the additional.php is not idempotent, I'd say it is misusing this API. If this isn't documented yet, then we should do so.
  6. Oliver Hader voted on patch set 1 CR +1 05/08/26, 07:42

  7. Benjamin Kott voted on patch set 1 CR +1 V +1 05/11/26, 06:24

  8. Oliver Klee voted on patch set 1 CR +1 05/11/26, 06:58

  9. Benjamin Franzke voted on patch set 1 CR +2 V +2 05/11/26, 07:08

  10. Benjamin Franzke merged patch set 2 05/11/26, 07:08