Review main Merged

94024[TASK] Include current site in cache tag collection

Soren Malling CR +2 V +2 Easy +2 −0 updated 05/28/26, 07:56

Commit message

Adding the resolved site to the cache tags of the request
allows for simply flushing of cache on a "per site basis"

$this->cache->flushByTag("site_<siteIdentifier>")

Valuable for cleaning cache after changing
for ex. a site configuration.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Josua Vogel +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Soren Malling uploaded patch set 1 05/07/26, 12:29

  2. Soren Malling updated the commit message in patch set 2 05/07/26, 12:32

  3. core-ci voted on patch set 2 V -1 05/07/26, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101684

  4. core-ci voted on patch set 1 V -1 05/07/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101681

  5. Mathias Brodala commented on patch set 2 CR -1 05/08/26, 05:37

    SiteResolver.php:75

    This should be done in the FE RequestHandler instead IMO together with all other cache tags. This would also be skipped properly if caching is disabled altogether then.
  6. Soren Malling uploaded patch set 3 CR -1 V -1 05/08/26, 07:24

  7. Soren Malling commented on patch set 2 05/08/26, 07:25

    SiteResolver.php:75 Reply

    Good point +1 - much better entrypoint
  8. Mathias Brodala commented on patch set 3 05/08/26, 07:29

    RequestHandler.php:180

    Is there a reason this is not "site_" as prefix anymore? This would be more compact IMO.

    SiteResolver.php:25

    CI: you'll hear from us. ;-)
  9. core-ci voted on patch set 3 V -1 05/08/26, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101708

  10. Soren Malling uploaded patch set 4 V -1 05/08/26, 07:43

  11. Soren Malling commented on patch set 3 05/08/26, 07:44

    RequestHandler.php:180 Reply

    Matching the "pageId" concept - agree on the more compact type

    SiteResolver.php:25 Reply

    Love CI 😄
  12. Mathias Brodala voted on patch set 4 CR +1 05/08/26, 07:44

  13. core-ci voted on patch set 4 V -1 05/08/26, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101710

  14. core-ci voted on patch set 4 V +1 05/08/26, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101710

  15. Josua Vogel voted on patch set 4 CR +1 V +1 05/18/26, 18:26

  16. Josef Glatz voted on patch set 4 CR +1 05/18/26, 19:40

  17. Georg Ringer voted on patch set 4 CR +2 V +2 05/20/26, 19:54

  18. Georg Ringer merged patch set 5 05/20/26, 20:17

  19. Garvin Hicking commented on patch set 5 05/26/26, 17:25

    Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/94161 for a regression of this patch
  20. Benjamin Franzke wrote 05/28/26, 07:56

    Created a revert of this change as I955600122e865d15cad28532732861777328d7ce