Review main Merged

94025[BUGFIX] Use User setting "Max title length" consistently across the backend

Dennis Purisevic CR +2 V +2 Normal +92 −73 updated 06/30/26, 12:31

Commit message

The "Max title length" (titleLen) user setting is honored in the page
tree and list module, but ignored in multiple places in the backend.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 1720

  1. Dennis Purisevic uploaded patch set 1 05/07/26, 13:30

  2. core-ci voted on patch set 1 V -1 05/07/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101690

  3. core-ci voted on patch set 1 V +1 05/08/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101690

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 05/08/26, 08:53

  5. Garvin Hicking commented on patch set 1 05/08/26, 10:14

    (Related, maybe we could unify this: 94032: [BUGFIX] Append uid to backend breadcrumb labels | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94032 )
  6. Josua Vogel commented on patch set 1 05/15/26, 09:38

    I think it would make sense to move the logic into a function to simplify the code and make it easier to maintain.
  7. Josua Vogel commented on patch set 1 05/15/26, 09:40

    Reply

    like the helper function cropTitle inside RecordBreadcrumbProvider
  8. Dennis Purisevic uploaded patch set 2 CR +1 V +1 05/31/26, 17:28

  9. core-ci voted on patch set 2 V +1 05/31/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102727

  10. Dennis Purisevic commented on patch set 2 05/31/26, 17:38

    Reply

    Sry for the late response. Extracted the functionality into the BackendUtility and implemented it at any place where the user setting was used.
  11. Josua Vogel commented on patch set 2 CR +1 V +1 06/01/26, 05:22

    Reply

    Thank you!
  12. Garvin Hicking voted on patch set 2 CR +1 V +1 06/01/26, 06:34

  13. Anja Leichsenring voted on patch set 2 CR +1 V +1 06/01/26, 06:37

  14. Garvin Hicking voted on patch set 2 CR +2 V +2 06/01/26, 15:29

  15. Garvin Hicking merged patch set 3 06/01/26, 15:29

  16. Benni Mack commented on patch set 3 06/30/26, 08:30

    BackendUtility.php:1181

    I really wish we would have made this internal...
  17. Dennis Purisevic commented on patch set 3 06/30/26, 08:32

    BackendUtility.php:1181 Reply

    How come? And not possible anymore? Just to know it for next time.
  18. Benni Mack commented on patch set 3 06/30/26, 08:43

    BackendUtility.php:1181 Reply

    Dennis, my remark was rather meant for the Core Mergers :) We all want BackendUtility to die at some point... so on each LTS release, I try to deprecate as many methods as possible, replacing them with good / better APIs. With this new method added, it will only be removed in v16, as I need to follow the deprecation strategy in v15.
  19. Dennis Purisevic commented on patch set 3 06/30/26, 08:46

    BackendUtility.php:1181 Reply

    Ah okey 😄. But good to know.
  20. Garvin Hicking commented on patch set 3 06/30/26, 12:31

    BackendUtility.php:1181 Reply Unresolved

    But this was not introduced as a feature and just in a patchlevel. I would offer to tag it as internal?! But yeah, more reviews or a RFC document what should nit be added where would help :)