94025[BUGFIX] Use User setting "Max title length" consistently across the backend
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 23
- typo3/sysext/backend/Classes/Breadcrumb/RecordBreadcrumbProvider.php+3 −5
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+4 −4
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+3 −5
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+4 −3
- typo3/sysext/backend/Classes/Controller/Wizard/LocalizationController.php+4 −2
- typo3/sysext/backend/Classes/Controller/ContextualRecordEditController.php+6 −4
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+9 −8
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −0
- typo3/sysext/backend/Classes/ElementBrowser/DatabaseBrowser.php+1 −2
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+2 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+1 −4
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+1 −2
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+1 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+2 −1
- typo3/sysext/backend/Classes/Service/PageLinkMessageProvider.php+2 −1
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+3 −9
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php5+32 −3
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+1 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+1 −1
Review log 1720
-
Dennis Purisevic uploaded patch set 1 05/07/26, 13:30
-
core-ci voted on patch set 1 V -1 05/07/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101690
-
core-ci voted on patch set 1 V +1 05/08/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101690
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 05/08/26, 08:53
-
Garvin Hicking commented on patch set 1 05/08/26, 10:14
(Related, maybe we could unify this: 94032: [BUGFIX] Append uid to backend breadcrumb labels | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94032 ) -
Josua Vogel commented on patch set 1 05/15/26, 09:38
I think it would make sense to move the logic into a function to simplify the code and make it easier to maintain. -
Josua Vogel commented on patch set 1 05/15/26, 09:40
Reply
like the helper function cropTitle inside RecordBreadcrumbProvider -
Dennis Purisevic uploaded patch set 2
CR +1V +105/31/26, 17:28 -
core-ci voted on patch set 2 V +1 05/31/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102727
-
Dennis Purisevic commented on patch set 2 05/31/26, 17:38
Reply
Sry for the late response. Extracted the functionality into the BackendUtility and implemented it at any place where the user setting was used. -
Josua Vogel commented on patch set 2 CR +1 V +1 06/01/26, 05:22
Reply
Thank you! -
Garvin Hicking voted on patch set 2 CR +1 V +1 06/01/26, 06:34
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 06/01/26, 06:37
-
Garvin Hicking voted on patch set 2 CR +2 V +2 06/01/26, 15:29
-
Garvin Hicking merged patch set 3 06/01/26, 15:29
-
Benni Mack commented on patch set 3 06/30/26, 08:30
BackendUtility.php:1181I really wish we would have made this internal... -
Dennis Purisevic commented on patch set 3 06/30/26, 08:32
BackendUtility.php:1181ReplyHow come? And not possible anymore? Just to know it for next time. -
Benni Mack commented on patch set 3 06/30/26, 08:43
BackendUtility.php:1181ReplyDennis, my remark was rather meant for the Core Mergers :) We all want BackendUtility to die at some point... so on each LTS release, I try to deprecate as many methods as possible, replacing them with good / better APIs. With this new method added, it will only be removed in v16, as I need to follow the deprecation strategy in v15. -
Dennis Purisevic commented on patch set 3 06/30/26, 08:46
BackendUtility.php:1181ReplyAh okey 😄. But good to know. -
Garvin Hicking commented on patch set 3 06/30/26, 12:31
BackendUtility.php:1181Reply UnresolvedBut this was not introduced as a feature and just in a patchlevel. I would offer to tag it as internal?! But yeah, more reviews or a RFC document what should nit be added where would help :)