Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
94029[FEATURE] Add secrets store and key management
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/94029/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/94029/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 20
- Build/Sources/TypeScript/install/module/settings/secrets.tsnew+115 −0
- Build/tests/playwright/e2e/install-tool/install-tool.spec.ts+2 −1
- typo3/sysext/core/Classes/Command/SecretsDomainCreateCommand.phpnew+62 −0
- typo3/sysext/core/Classes/Command/SecretsDomainListCommand.phpnew+52 −0
- typo3/sysext/core/Classes/Command/SecretsDomainRemoveCommand.phpnew+62 −0
- typo3/sysext/core/Classes/Command/SecretsKeyAddCommand.phpnew+83 −0
- typo3/sysext/core/Classes/Command/SecretsKeyListCommand.phpnew+62 −0
- typo3/sysext/core/Classes/Command/SecretsKeyRemoveCommand.phpnew+71 −0
- typo3/sysext/core/Classes/Security/SecretsFactory.phpnew+47 −0
- typo3/sysext/core/Documentation/Changelog/14.3.x/Feature-109797-SecretsStoreAndKeyManagement.rstnew+175 −0
- typo3/sysext/core/Tests/Functional/Security/SecretsFactoryTest.phpnew+78 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/install/Classes/Controller/SettingsController.php+124 −1
- typo3/sysext/install/Classes/ServiceProvider.php+10 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/Cards.fluid.html+9 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/SecretsGetContent.fluid.htmlnew+143 −0
- typo3/sysext/install/Resources/Public/Icons/modules/install-manage-secrets.svgnew+52 −0
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/secrets.jsnew+13 −0
- composer.json+1 −0
- composer.lock+46 −1
Review log 914
-
Oliver Hader uploaded patch set 1 05/08/26, 07:41
-
core-ci voted on patch set 1 V -1 05/08/26, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101709
-
Oliver Hader uploaded patch set 2
V -105/08/26, 08:20 -
core-ci voted on patch set 2 V +1 05/08/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101711
-
Helmut Hummel commented on patch set 2 05/08/26, 11:26
I might be missing something very obvious, but can you add an example how to exactly add an API key to the store and how that can be retrieved? Or is this out of scope and this only add the possibility to get hold of the symmetric key (one symmetric key for each domain), which can then be used to actually encrypt and decrypt the values the application consumes? -
Oliver Hader commented on patch set 2 05/08/26, 13:42
Reply
Thx. I planned to add tests for the whole trip (key handling and encrypting/decrypting values). Sealing/Unsealing would happen in the corresponding cipher service of the (currently) external library: https://github.com/ohader/secrets-kms/blob/main/src/Cipher.php -
Oliver Hader uploaded patch set 3
V +105/08/26, 13:57 -
core-ci voted on patch set 3 V +1 05/08/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101732
-
Oliver Hader uploaded patch set 4
V +105/11/26, 16:15 -
Oliver Hader commented on patch set 4 05/11/26, 16:16
Find the screenshots of the install tool UI at https://forge.typo3.org/issues/109797 -
core-ci voted on patch set 4 V -1 05/11/26, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101840
-
Oliver Hader uploaded patch set 5
V -105/12/26, 06:30 -
core-ci voted on patch set 5 V +1 05/12/26, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101860
-
Oliver Hader commented on patch set 5 05/13/26, 15:29
Reply
Done