Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

94029[FEATURE] Add secrets store and key management

Oliver Hader CR 0 V 0 Expert +1208 −3 updated 05/13/26, 15:29

Commit message

@todo:
+ Clarify, whether to backport this feature. Stay relaxed...
+ Probably merge oliver-hader/secrets-kms to core directyl.

Integrates oliver-hader/secrets-kms, a libsodium-based
file-backed KMS using X25519 sealed-box encryption.

Introduces SecretsFactory to centralise Manager creation
from the installation's encryptionKey and config-path
storage, and six CLI commands:

  secrets:key:add / remove / list
  secrets:domain:create / remove / list

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/94029/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/94029/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 20

Review log 914

  1. Oliver Hader uploaded patch set 1 05/08/26, 07:41

  2. core-ci voted on patch set 1 V -1 05/08/26, 07:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101709

  3. Oliver Hader uploaded patch set 2 V -1 05/08/26, 08:20

  4. core-ci voted on patch set 2 V +1 05/08/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101711

  5. Helmut Hummel commented on patch set 2 05/08/26, 11:26

    I might be missing something very obvious, but can you add an example how to exactly add an API key to the store and how that can be retrieved? Or is this out of scope and this only add the possibility to get hold of the symmetric key (one symmetric key for each domain), which can then be used to actually encrypt and decrypt the values the application consumes?
  6. Oliver Hader commented on patch set 2 05/08/26, 13:42

    Reply

    Thx. I planned to add tests for the whole trip (key handling and encrypting/decrypting values). Sealing/Unsealing would happen in the corresponding cipher service of the (currently) external library: https://github.com/ohader/secrets-kms/blob/main/src/Cipher.php
  7. Oliver Hader uploaded patch set 3 V +1 05/08/26, 13:57

  8. core-ci voted on patch set 3 V +1 05/08/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101732

  9. Oliver Hader uploaded patch set 4 V +1 05/11/26, 16:15

  10. Oliver Hader commented on patch set 4 05/11/26, 16:16

    Find the screenshots of the install tool UI at https://forge.typo3.org/issues/109797
  11. core-ci voted on patch set 4 V -1 05/11/26, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101840

  12. Oliver Hader uploaded patch set 5 V -1 05/12/26, 06:30

  13. core-ci voted on patch set 5 V +1 05/12/26, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101860

  14. Oliver Hader commented on patch set 5 05/13/26, 15:29

    Reply

    Done