Review 12.4 Abandoned

94035[TASK] Adjust creation of indexes on junction tables

TYPO3com CR 0 V 0 Normal +122 −30 updated 05/08/26, 10:17

Commit message

* Remove redundant index on `uid_local`, as it is already covered by the
composite primary key (`uid_local`, `uid_foreign`) or (`uid_local`,
`uid_foreign`, `tablenames`, `fieldname`) if `tablenames` and `fieldname`
are provided. A reverse lookup index on `uid_foreign` is sufficient, since
it already includes the primary key columns.
* Add a unique index on (`uid_local`, `uid_foreign`) and include
`tablenames` and `fieldname` columns if they are provided for the case
when a primary key `uid` is needed. A reverse lookup composite index on
(`uid_foreign`, `uid_local`) is created in this case.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 13

  1. TYPO3com uploaded patch set 1 05/08/26, 09:49

  2. core-ci voted on patch set 1 V +1 05/08/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101720

  3. Garvin Hicking abandoned the change 05/08/26, 10:17

    will only keep "main" a dupes