94040[BUGFIX] Fix workspace split preview URLs for access-restricted pages
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+12 −7
- typo3/sysext/adminpanel/Configuration/RequestMiddlewares.php+1 −0
- typo3/sysext/adminpanel/Tests/Functional/Modules/PreviewModuleTest.php+48 −0
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+19 −8
- typo3/sysext/frontend/Classes/Preview/PreviewSimulatorCalculator.phpnew+49 −0
- typo3/sysext/frontend/Tests/Unit/Preview/PreviewSimulatorCalculatorTest.phpnew+68 −0
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+20 −10
- typo3/sysext/workspaces/Tests/Functional/Controller/Fixtures/fe_groups.csvnew+3 −0
- typo3/sysext/workspaces/Tests/Functional/Controller/Fixtures/pages.csvnew+18 −0
- typo3/sysext/workspaces/Tests/Functional/Controller/PreviewControllerTest.php+138 −15
Review log 2845
Show 1120 earlier messages
-
Philipp Kitzberger uploaded patch set 1 05/08/26, 13:36
-
Benni Mack updated the commit message in patch set 2 05/08/26, 13:39
-
core-ci voted on patch set 2 V +1 05/08/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101730
-
core-ci voted on patch set 1 V +1 05/08/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101728
-
Philipp Kitzberger uploaded patch set 3
V +105/09/26, 08:50 -
core-ci voted on patch set 3 V +1 05/09/26, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101751
-
Philipp Kitzberger uploaded patch set 4
V +105/21/26, 10:55 -
core-ci voted on patch set 4 V -1 05/21/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102311
-
Philipp Kitzberger uploaded patch set 5
V -105/25/26, 07:24 -
core-ci voted on patch set 5 V +1 05/25/26, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102399
-
Josua Vogel voted on patch set 5 CR +1 V +1 09/09/26, 10:18
-
Benni Mack commented on patch set 5 09/09/26, 10:21
looking at the code, I'd really like to have a test for the PreviewController as well, so we know that any further changes won't break this again. In addition, we could build a small PreviewSimulatorCalculator in EXT:frontend that does the conversion, and both PreviewSimulator and PreviewController consuem the class. This way, we only need to (unit-) test the new class. WDYT? -
Josua Vogel uploaded patch set 6
CR +1V +109/09/26, 12:09 -
core-ci voted on patch set 6 V +1 09/09/26, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108174
-
Josua Vogel uploaded patch set 7
V +109/09/26, 12:41 -
Josua Vogel uploaded patch set 8 09/09/26, 12:43
-
core-ci voted on patch set 7 V -1 09/09/26, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108178
-
core-ci voted on patch set 8 V -1 09/09/26, 12:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108179
-
Josua Vogel uploaded patch set 9
V -109/09/26, 13:48 -
core-ci voted on patch set 9 V -1 09/09/26, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108188
-
Josua Vogel uploaded patch set 10
V -110/22/26, 20:10 -
Josua Vogel commented on patch set 10 10/22/26, 20:12
Reply
Done -
core-ci voted on patch set 10 V +1 10/22/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112185
-
Benni Mack uploaded patch set 11
V +111/01/26, 07:13 -
core-ci voted on patch set 11 V -1 11/01/26, 07:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112993
-
Benni Mack rebased onto patch set 12
V -111/01/26, 11:42 -
core-ci voted on patch set 12 V +1 11/01/26, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113011
-
Josua Vogel uploaded patch set 13
V +111/03/26, 11:57 -
Josua Vogel commented on patch set 13 11/03/26, 12:02
added -2 as simulated user group -
core-ci voted on patch set 13 V -1 11/03/26, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113152
-
core-ci voted on patch set 13 V +1 11/03/26, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113152
-
Josua Vogel voted on patch set 13 CR +1 V +1 11/03/26, 13:29
-
Simon Schaufelberger voted on patch set 13 CR +1 V +1 11/06/26, 00:55
-
Benni Mack commented on patch set 13 11/09/26, 15:45
We still need to adapt "admin panel" logic as well. Maybe we can centralize this completely? not just for simUser but also fro simTime. -
Benni Mack voted on patch set 13 CR -1 11/09/26, 15:45
-
Benni Mack uploaded patch set 14
CR +1V +111/18/26, 20:29 -
core-ci voted on patch set 14 V +1 11/18/26, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114921
-
Benni Mack uploaded patch set 15
V +111/18/26, 22:05 -
Benni Mack uploaded patch set 16 11/18/26, 22:13
-
core-ci voted on patch set 15 V +1 11/18/26, 22:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114935
-
core-ci voted on patch set 16 V +1 11/18/26, 22:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114936
-
Benni Mack voted on patch set 16 CR +1 V +1 11/19/26, 07:13
-
Josua Vogel voted on patch set 16 CR +1 V +1 11/19/26, 07:51
-
Benni Mack voted on patch set 16 CR +2 V +2 11/19/26, 08:21
-
Benni Mack merged patch set 17 11/19/26, 08:25