Review main Merged

94042[BUGFIX] Fix invalid class path for PHPStorm meta

Simon Schaufelberger CR +2 V +2 Easy +2 −2 updated 05/10/26, 16:55

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1014

  1. Simon Schaufelberger uploaded patch set 1 05/09/26, 18:26

  2. core-ci voted on patch set 1 V +1 05/09/26, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101759

  3. Garvin Hicking updated the commit message in patch set 2 V +1 05/09/26, 19:07

  4. Garvin Hicking commented on patch set 2 05/09/26, 19:08

    Is 13.4 affected too? Was this renamed in v14? If so maybe set "Related:"
  5. core-ci voted on patch set 2 V +1 05/09/26, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101760

  6. Simon Schaufelberger updated the commit message in patch set 3 V +1 05/09/26, 19:27

  7. Simon Schaufelberger commented on patch set 3 05/09/26, 19:28

    Reply

    yes 13.4 is also affected. I changed the Message
  8. core-ci voted on patch set 3 V +1 05/09/26, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101761

  9. Garvin Hicking commented on patch set 4 V +1 05/09/26, 22:49

    Published edit on patch set 3.
  10. Garvin Hicking commented on patch set 4 CR +1 V +1 05/09/26, 22:49

    Reply

    Ack. I also fixed the wrong class a few lines below, and added the `Related`.
  11. core-ci voted on patch set 4 V +1 05/09/26, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101762

  12. Josua Vogel voted on patch set 4 CR +1 V +1 05/10/26, 11:32

  13. Garvin Hicking voted on patch set 4 CR +2 V +2 05/10/26, 13:30

  14. Garvin Hicking merged patch set 5 05/10/26, 16:55