94073[BUGFIX] Properly parse dateTimeFirstDayOfWeek when not yet set
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Sebastian Iffland +1
- Josua Vogel +1
-
Verified V +2 Done
- Oliver Hader +2
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 2
Review log 912
-
Garvin Hicking uploaded patch set 1 05/12/26, 06:34
-
core-ci voted on patch set 1 V +1 05/12/26, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101861
-
Oliver Klee updated the commit message in patch set 2
V +105/12/26, 07:09 -
core-ci voted on patch set 2 V +1 05/12/26, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101865
-
Josua Vogel uploaded patch set 3
V +105/12/26, 07:37 -
Josua Vogel commented on patch set 3 CR +1 V +1 05/12/26, 07:39
I simplified the condition loose null-check (!= null) which covers undefined and null -
core-ci voted on patch set 3 V +1 05/12/26, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101870
-
Sebastian Iffland voted on patch set 3 CR +1 05/12/26, 07:53
-
Oliver Hader commented on patch set 3 CR +1 V +1 05/12/26, 07:54
date-time-picker.ts:76Implicit `undefined` check - however it seems to be fine to use the non-strict `!=` comparison here. -
Oliver Hader commented on patch set 3 05/12/26, 07:59
date-time-picker.ts:76ReplyBesides that, I guess it can be simplified, since `dow` (from the settings) is from `1` to `7`. Thus, `if (dow > 0) {}` would be fine as well - wouldn't it? -
Oliver Hader voted on patch set 3 CR +2 V +2 05/12/26, 08:43
-
Oliver Hader merged patch set 4 05/12/26, 09:00