Review main Merged

94074[DOCS] Fix namespace for QueryResultPaginator in changelog

Chris Müller CR +2 V +2 Easy +1 −1 updated 05/12/26, 13:52

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Chris Müller uploaded patch set 1 05/12/26, 08:40

  2. core-ci voted on patch set 1 V -1 05/12/26, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101875

  3. Chris Müller updated the commit message in patch set 2 05/12/26, 08:55

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  4. core-ci voted on patch set 1 V +1 05/12/26, 08:56 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (was Verified-1) (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101875

  5. core-ci voted on patch set 2 V +1 05/12/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101877

  6. Garvin Hicking commented on patch set 2 05/12/26, 12:42

    Feature-102194-QueryBuilderPaginator.rst:38

    the namespace of this is in "Core", what am I missing?
  7. Garvin Hicking commented on patch set 2 CR +1 V +1 05/12/26, 12:45

    Feature-102194-QueryBuilderPaginator.rst:38 Reply

    Oh lol now I see QueryResultPaginator vs QueryBuilderPaginator, sorry!
  8. Chris Müller commented on patch set 2 05/12/26, 12:46

  9. Chris Müller commented on patch set 2 05/12/26, 12:46

    Feature-102194-QueryBuilderPaginator.rst:38 Reply

    Acknowledged
  10. Josua Vogel voted on patch set 2 CR +1 V +1 05/12/26, 13:24

  11. Benni Mack voted on patch set 2 CR +2 V +2 05/12/26, 13:51

  12. Benni Mack merged patch set 3 05/12/26, 13:52