Review 14.3 Merged

94075[BUGFIX] Properly parse dateTimeFirstDayOfWeek when not yet set

Oliver Hader CR +2 V +2 Easy +2 −2 updated 05/12/26, 09:00

Commit message

After Feature #108463 ("User-specific configuration of
date-timepicker's first day of a week", introduced in 14.1),
the backend date-time picker renders a broken calendar grid
for any backend user whose `be_users.uc` does not contain a
dateTimeFirstDayOfWeek entry — which is the default state
for every user that hasn't opened the User Settings module
since the upgrade.

In the broken state, the calendar lays the days out sequentially
starting in the leftmost column: the 1st of every month appears
in column 0, the 2nd in column 1, etc., regardless of the actual
weekday. The week header is rendered correctly, so the
misalignment is immediately visible (e.g. December 1st
2026 is shown under "Sun" although it is a Tuesday).

This patch properly guards the `dow` variable to also catch
undefined/null values.

Thanks to Oliver Heins for reporting the bug and providing
a working fix.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 05/12/26, 08:44

  2. core-ci voted on patch set 1 V +1 05/12/26, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101876

  3. Oliver Hader voted on patch set 1 CR +2 V +2 05/12/26, 09:00

  4. Oliver Hader merged patch set 2 05/12/26, 09:00